Skip to content

Update mergify to prevent incorrectly firing rule to update ready-for-review label #7525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/mergify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,17 +48,16 @@ pull_request_rules:
# CI workflows approvals.
- check-success=test-suite-success
- check-success=local-testnet-success
- "#review-requested > 0"
# Update the label only if there are no more change requests from any reviewers and no unresolved threads.
# This rule ensures that a PR with passing CI can be marked as `waiting-on-author`.
- "#changes-requested-reviews-by = 0"
- "#review-threads-unresolved = 0"
actions:
label:
remove:
- waiting-on-author
add:
- ready-for-review
comment:
message: >
All required checks have passed and there are no merge conflicts.
This pull request may now be ready for another review.

- name: Close stale pull request after 30 days of inactivity
conditions:
Expand Down
Loading