Skip to content

Cleanup consensus/types re-exports #8643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 5 commits into from
Jan 15, 2026
Merged

Cleanup consensus/types re-exports #8643

mergify merged 5 commits into from
Jan 15, 2026

Conversation

@macladson
Copy link
Member

@macladson macladson commented Jan 11, 2026

Proposed Changes

Removes some of the temporary re-exports in consensus/types.

I am doing this in multiple parts to keep each diff small.

@macladson macladson added ready-for-review The code is ready for review code-quality low-hanging-fruit Easy to resolve, get it before someone else does! labels Jan 11, 2026
@mergify
Copy link

mergify bot commented Jan 11, 2026

Some required checks have failed. Could you please take a look @macladson? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jan 11, 2026
@mergify mergify bot added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jan 11, 2026
pawanjay176
pawanjay176 approved these changes Jan 13, 2026
View reviewed changes
Copy link
Member

@pawanjay176 pawanjay176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pawanjay176 pawanjay176 added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jan 15, 2026
@mergify mergify bot added the queued label Jan 15, 2026
@mergify
Copy link

mergify bot commented Jan 15, 2026 •
edited
Loading

Merge Queue Status

✅ The pull request has been merged at 23ea426

This pull request spent 40 minutes 19 seconds in the queue, including 38 minutes 42 seconds running CI.
The checks were run on draft #8664.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

mergify bot added a commit that referenced this pull request Jan 15, 2026
@mergify
Merge of #8643
3a76324
@mergify mergify bot mentioned this pull request Jan 15, 2026
Closed
6 tasks
@mergify mergify bot merged commit 1abc41e into sigp:unstable Jan 15, 2026
36 checks passed
@mergify mergify bot removed the queued label Jan 15, 2026
@macladson macladson mentioned this pull request Jan 15, 2026
Merged
@macladson macladson deleted the types-reexport-cleanup-1 branch January 15, 2026 03:08
@macladson macladson mentioned this pull request Jan 16, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pawanjay176 pawanjay176 pawanjay176 approved these changes

Assignees

No one assigned

Labels

code-quality low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@macladson @pawanjay176