Skip to content

Conversation

@macladson
Copy link
Member

Proposed Changes

Swaps out the local_ip_address dependency for if-addrs. The reason for this is that is that local_ip_address is a relatively heavy dependency (depends on neli) compared to if-addrs and we only use it to check the presence of an IPv6 interface. This is an experiment to see if we can use the more lightweight if-addrs instead.

Additional Info

Note that the older if-addrs version 0.10 exists in our Cargo.lock as an optional dependency of if-watch but we do not actually compile it

@macladson macladson requested a review from jxs as a code owner January 14, 2026 03:17
@macladson macladson added code-quality Networking dependencies Pull requests that update a dependency file ready-for-review The code is ready for review labels Jan 14, 2026
@macladson
Copy link
Member Author

After talking to @jxs, I'm going to try to see if we can use if-watch directly here instead

@mergify
Copy link

mergify bot commented Jan 21, 2026

This pull request has merge conflicts. Could you please resolve them @macladson? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jan 21, 2026
@macladson
Copy link
Member Author

@jxs what do you think about merging this one? I've pretty much given up on #8662 but feel free to play around with it if you think it's worth it

@mergify mergify bot added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-quality dependencies Pull requests that update a dependency file Networking ready-for-review The code is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants