Skip to content

Updated consensus types for Gloas 1.7.0-alpha.1 #8688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 10 commits into from
Jan 21, 2026
Merged

Updated consensus types for Gloas 1.7.0-alpha.1 #8688

mergify merged 10 commits into from
Jan 21, 2026

Conversation

@jimmygchen
Copy link
Member

@jimmygchen jimmygchen commented Jan 21, 2026

Issue Addressed

Pulling out consensus type changes from #8677.

This PR covers all type changes for spec 1.7.0-alpha.1 (except for DataColumnSidecar changes, which is covered in @eserilev's PR #8682)

@jimmygchen @michaelsproul
@shane-moore @ethDreamer
Updated consensus types for gloas 1.7.0-alpha.1.
bd68143 
Co-authored-by: Michael Sproul <michael@sigmaprime.io>
Co-authored-by: shane-moore <skm1790@gmail.com>
Co-authored-by: ethDreamer <37123614+ethdreamer@users.noreply.github.com>
@jimmygchen jimmygchen added ready-for-review The code is ready for review gloas labels Jan 21, 2026
jimmygchen
jimmygchen commented Jan 21, 2026
View reviewed changes
@mergify
Copy link

mergify bot commented Jan 21, 2026

Some required checks have failed. Could you please take a look @jimmygchen? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jan 21, 2026
@jimmygchen jimmygchen mentioned this pull request Jan 21, 2026
Open
@jimmygchen jimmygchen added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jan 21, 2026
michaelsproul
michaelsproul approved these changes Jan 21, 2026
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peer reviewed with Jimmy

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jan 21, 2026
@mergify mergify bot added the queued label Jan 21, 2026
@mergify
Copy link

mergify bot commented Jan 21, 2026 •
edited
Loading

Merge Queue Status

🚫 The pull request has left the queue (rule: default) at f9e5b4c

This pull request spent 25 minutes 41 seconds in the queue, including 23 minutes 4 seconds running CI.
The checks were run on draft #8690.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

Reason

The merge conditions cannot be satisfied due to failing checks

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify bot added a commit that referenced this pull request Jan 21, 2026
@mergify
Merge of #8688
38790c9
@mergify mergify bot mentioned this pull request Jan 21, 2026
Closed
6 tasks
@mergify mergify bot added dequeued and removed queued labels Jan 21, 2026
@michaelsproul
Copy link
Member

michaelsproul commented Jan 21, 2026

@mergify requeue

@mergify
Copy link

mergify bot commented Jan 21, 2026

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify
Copy link

mergify bot commented Jan 21, 2026 •
edited
Loading

Merge Queue Status

✅ The pull request has been merged at f9e5b4c

This pull request spent 40 minutes 54 seconds in the queue, including 39 minutes 23 seconds running CI.
The checks were run on draft #8691.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

@mergify mergify bot added queued and removed dequeued labels Jan 21, 2026
mergify bot added a commit that referenced this pull request Jan 21, 2026
@mergify
Merge of #8688
24c0196
@mergify mergify bot mentioned this pull request Jan 21, 2026
Closed
6 tasks
@mergify mergify bot merged commit 21cabba into sigp:unstable Jan 21, 2026
36 checks passed
@mergify mergify bot removed the queued label Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees

No one assigned

Labels

gloas ready-for-merge This PR is ready to merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jimmygchen @michaelsproul