Update SHARDING.md for lb monitoring #535
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Appu <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #535 +/- ##
=======================================
Coverage 35.10% 35.10%
=======================================
Files 44 44
Lines 3225 3225
=======================================
Hits 1132 1132
Misses 1990 1990
Partials 103 103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| Follow the example below, updating the `shard_name`. | ||
|
|
||
| [Example PR](https://github.com/sigstore/public-good-instance/pull/3282) | ||
| [Example PR](https://github.com/sigstore/public-good-instance/pull/3282), see [source changed PR](https://github.com/sigstore/public-good-instance/commit/638fc9953997cc22ccb66008a0bff2259b3bc97b#diff-ec1861c7f7eb84faa3fdda00bb1ea76a656007a9c218cbc7076f628518023114L360-R360) for updated module path. |
Contributor
There was a problem hiding this comment.
This doesn't seem to link correctly. Can you write what the correct module path is without the link?
| [Example PR](https://github.com/sigstore/public-good-instance/pull/3282) | ||
| [Example PR](https://github.com/sigstore/public-good-instance/pull/3282), see [source changed PR](https://github.com/sigstore/public-good-instance/commit/638fc9953997cc22ccb66008a0bff2259b3bc97b#diff-ec1861c7f7eb84faa3fdda00bb1ea76a656007a9c218cbc7076f628518023114L360-R360) for updated module path. | ||
|
|
||
| Additionally, add the new shard as an active shard in the load balancer metrics [Initial PR](https://github.com/sigstore/public-good-instance/pull/3311/files#diff-ec1861c7f7eb84faa3fdda00bb1ea76a656007a9c218cbc7076f628518023114R379) |
Contributor
There was a problem hiding this comment.
Suggested change
| Additionally, add the new shard as an active shard in the load balancer metrics [Initial PR](https://github.com/sigstore/public-good-instance/pull/3311/files#diff-ec1861c7f7eb84faa3fdda00bb1ea76a656007a9c218cbc7076f628518023114R379) | |
| Additionally, add the new shard as an active shard in the load balancer metrics - [Initial PR](https://github.com/sigstore/public-good-instance/pull/3311/files#diff-ec1861c7f7eb84faa3fdda00bb1ea76a656007a9c218cbc7076f628518023114R379) |
|
|
||
| [Example PR](https://github.com/sigstore/public-good-instance/pull/3175) | ||
|
|
||
| Move the shard to the frozen_shard section of loadbalancer metrics in `staging.tf` or |
Contributor
There was a problem hiding this comment.
Suggested change
| Move the shard to the frozen_shard section of loadbalancer metrics in `staging.tf` or | |
| Move the shard to the `frozen_shards` section of loadbalancer metrics in `staging.tf` or |
cmurphy
reviewed
Oct 1, 2025
| Move the shard to the frozen_shard section of loadbalancer metrics in `staging.tf` or | ||
| `production.tf`. | ||
|
|
||
| [Initial PR](https://github.com/sigstore/public-good-instance/pull/3311/files#diff-ec1861c7f7eb84faa3fdda00bb1ea76a656007a9c218cbc7076f628518023114R379) |
Contributor
There was a problem hiding this comment.
Suggested change
| [Initial PR](https://github.com/sigstore/public-good-instance/pull/3311/files#diff-ec1861c7f7eb84faa3fdda00bb1ea76a656007a9c218cbc7076f628518023114R379) | |
| [Initial PR](https://github.com/sigstore/public-good-instance/pull/3311/files#diff-ec1861c7f7eb84faa3fdda00bb1ea76a656007a9c218cbc7076f628518023114R380) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Release Note
Documentation