Skip to content

Update SHARDING.md for lb monitoring #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loosebazooka wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update SHARDING.md for lb monitoring #535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions SHARDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,9 @@ Run `terraform apply` using
Now that the service is deployed, create the metrics, alerts and dashboards for the service.
Follow the example below, updating the `shard_name`.

[Example PR](https://github.com/sigstore/public-good-instance/pull/3282)
[Example PR](https://github.com/sigstore/public-good-instance/pull/3282), see [source changed PR](https://github.com/sigstore/public-good-instance/commit/638fc9953997cc22ccb66008a0bff2259b3bc97b#diff-ec1861c7f7eb84faa3fdda00bb1ea76a656007a9c218cbc7076f628518023114L360-R360) for updated module path.
Copy link
Contributor

@haydentherapper haydentherapper Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to link correctly. Can you write what the correct module path is without the link?


Additionally, add the new shard as an active shard in the load balancer metrics [Initial PR](https://github.com/sigstore/public-good-instance/pull/3311/files#diff-ec1861c7f7eb84faa3fdda00bb1ea76a656007a9c218cbc7076f628518023114R379)
Copy link
Contributor

@haydentherapper haydentherapper Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Additionally, add the new shard as an active shard in the load balancer metrics [Initial PR](https://github.com/sigstore/public-good-instance/pull/3311/files#diff-ec1861c7f7eb84faa3fdda00bb1ea76a656007a9c218cbc7076f628518023114R379)
Additionally, add the new shard as an active shard in the load balancer metrics - [Initial PR](https://github.com/sigstore/public-good-instance/pull/3311/files#diff-ec1861c7f7eb84faa3fdda00bb1ea76a656007a9c218cbc7076f628518023114R379)


Merge, `terraform plan`, and `terraform apply`.

Expand Down Expand Up @@ -490,10 +492,17 @@ for failing healthchecks for the write path or missing metrics. As we turn down
and delete resources, we expect that healthchecks will start to fail.

Remove the monitoring module from Terraform, either from `staging.tf` or `production.tf`.
Merge and run `terraform plan` and `terraform apply`.

[Example PR](https://github.com/sigstore/public-good-instance/pull/3175)

Move the shard to the frozen_shard section of loadbalancer metrics in `staging.tf` or
Copy link
Contributor

@haydentherapper haydentherapper Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Move the shard to the frozen_shard section of loadbalancer metrics in `staging.tf` or
Move the shard to the `frozen_shards` section of loadbalancer metrics in `staging.tf` or

`production.tf`.

[Initial PR](https://github.com/sigstore/public-good-instance/pull/3311/files#diff-ec1861c7f7eb84faa3fdda00bb1ea76a656007a9c218cbc7076f628518023114R379)
Copy link
Contributor

@cmurphy cmurphy Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Initial PR](https://github.com/sigstore/public-good-instance/pull/3311/files#diff-ec1861c7f7eb84faa3fdda00bb1ea76a656007a9c218cbc7076f628518023114R379)
[Initial PR](https://github.com/sigstore/public-good-instance/pull/3311/files#diff-ec1861c7f7eb84faa3fdda00bb1ea76a656007a9c218cbc7076f628518023114R380)


Merge and run `terraform plan` and `terraform apply`.


As we create more alerting, we'll finalize this section with specific alerts to remove.
We may need to add a `freeze_shard` variable that disables write-only metrics.
For now, we'll remove the entire monitoring module.
Expand Down