Merged
Conversation
23 tasks
emteknetnz
force-pushed
the
main
branch
12 times, most recently
from
c8bd035 to
ab6c140
Compare
Member
GuySartorelli
left a comment
GuySartorelli
left a comment
There was a problem hiding this comment.
Would it make sense for the setup steps in the test job ("Configure PHP", "Apt install additional requirements ", "Configure apache - endtoend test") to be included as separate .sh files which can just be executed from here?
GuySartorelli
requested changes
Jun 7, 2022
Member
GuySartorelli
left a comment
GuySartorelli
left a comment
There was a problem hiding this comment.
Forgot to check "request changes"
emteknetnz
force-pushed
the
main
branch
9 times, most recently
from
4d10a0c to
f703bee
Compare
emteknetnz
force-pushed
the
main
branch
2 times, most recently
from
b3fa69a to
ae68d10
Compare
GuySartorelli
requested changes
Jun 10, 2022
emteknetnz
force-pushed
the
main
branch
2 times, most recently
from
4f98310 to
d45c40a
Compare
GuySartorelli
requested changes
Jun 13, 2022
| run: | | ||
| # apache2 is installed and running by default in ubuntu | ||
| # update dir.conf to use index.php as the primary index doc | ||
| cat << EOF > __dir.conf |
Member
There was a problem hiding this comment.
Please make this small change. If this syntax still doesn't work for some reason I'll concede it's not worth worrying about.
GuySartorelli
approved these changes
Jun 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/github-actions-ci-cd#36