-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Feat/env example in apps sim #1836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat/env example in apps sim #1836
Conversation
…oai#1608) * improvement(performance): remove unused source/target indices, add index on snapshot id (simstudioai#1603) * fix(blog): rename building to blogs with redirect (simstudioai#1604) * improvement(privacy-policy): updated privacy policy for google (simstudioai#1602) * updated privacy policy for google * update terms, privacy, and emails to incl address and update verbiage * feat(guardrails): added guardrails block/tools and docs (simstudioai#1605) * Adding guardrails block * ack PR comments * cleanup checkbox in dark mode * cleanup * fix supabase tools * fix(inference-billing): fix inference billing when stream is true via API, add drag-and-drop functionality to deployed chat (simstudioai#1606) * fix(inference): fix inference billing when stream is true via API * add drag-and-drop to deployed chat * feat(mistal): added mistral as a provider, updated model prices (simstudioai#1607) * feat(mistal): added mistral as a provider, updated model prices * remove the ability for a block to reference its own outluts * fixed order of responses for guardrails block * feat(versions): added the ability to rename deployment versions (simstudioai#1610) * fix(vulns): fix various vulnerabilities and enhanced code security (simstudioai#1611) * fix(vulns): fix SSRF vulnerabilities * cleanup * cleanup * regen docs * remove unused deps * fix failing tests * cleanup * update deps * regen bun lock
…ad support for more blocks
…hboard improvements
) * fix(debug-mode): remove duplicate debug mode flag (simstudioai#1714) * feat(i18n): update translations (simstudioai#1709) * improvement(condition): added variable and envvar highlighting for condition input (simstudioai#1718) * fix(dashboard): add additional context for paginated logs in dashboard, add empty state when selected cell has no data (simstudioai#1719) * fix(dashboard): add additional context for paginated logs in dashboard, add empty state when selected cell has no data * apps/sim * renaming * remove relative import * feat(tools): added webflow OAuth + tools (simstudioai#1720) * feat(tools): added webflow OAuth + tools * remove itemId from delete item * remove siteId * added webhook triggers + oauth scopes + site/collection selector * update sample payload for webflow triggers * cleanup * fix discord color * feat(i18n): update translations (simstudioai#1721) * improvement(schedule): fix UI bug with schedule modal (simstudioai#1722)
* fix(already-cancelled-sub): UI should allow restoring subscription * restore functionality fixed * fix
…cp improvements, local kb file storage
…ables Added example environment variables for application configuration.
Added NEXT_PUBLIC_APP_URL to environment variable configuration.
|
@sundaram2021 is attempting to deploy a commit to the Sim Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Greptile Summary
This PR adds comprehensive environment variable documentation to the project by:
-
Creating
apps/sim/.env.example- A well-organized example configuration file with 292 environment variables grouped into three categories:- Required Variables: Core functionality variables like
DATABASE_URL,BETTER_AUTH_SECRET,BETTER_AUTH_URL, andNEXT_PUBLIC_APP_URL - Required For Certain Operations: Feature-specific variables (AI providers, cloud storage, OAuth integrations, etc.)
- Optional Variables: Configuration overrides and optional features
- Required Variables: Core functionality variables like
-
Updating README.md - Added
NEXT_PUBLIC_APP_URLto the list of required environment variables in the setup instructions (line 120), ensuring developers are aware of all core configuration requirements.
The .env.example file provides comprehensive inline documentation for each variable, including its purpose, expected format, and when it's needed. This significantly improves the developer onboarding experience by making environment setup more discoverable and self-documenting.
The addition of NEXT_PUBLIC_APP_URL to the README is important as this variable is required in apps/sim/lib/env.ts:252 and used for environment detection in apps/sim/lib/environment.ts:25-26.
Confidence Score: 5/5
- This PR is safe to merge with no risk - it only adds documentation
- Documentation-only change that improves developer experience. The addition of
NEXT_PUBLIC_APP_URLto the README correctly reflects the required environment variable defined in env.ts. The comprehensive .env.example file provides excellent documentation with clear categorization and inline comments. - No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| README.md | 5/5 | Updated environment variable setup instructions to include NEXT_PUBLIC_APP_URL |
| apps/sim/.env.example | 5/5 | Comprehensive environment configuration example with 292 variables organized by category |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant Repo as Repository
participant README as README.md
participant EnvExample as .env.example
participant LocalEnv as .env (local)
participant App as Application
Dev->>Repo: Clone repository
Dev->>README: Read setup instructions
README-->>Dev: Shows required vars: DATABASE_URL, BETTER_AUTH_SECRET, BETTER_AUTH_URL, NEXT_PUBLIC_APP_URL
Dev->>EnvExample: Copy .env.example to .env
EnvExample-->>LocalEnv: Creates local config with all variables
Note over EnvExample,LocalEnv: 292 variables organized:<br/>- Required (core)<br/>- Required (features)<br/>- Optional
Dev->>LocalEnv: Configure required variables
LocalEnv-->>App: Provides configuration
App->>App: Validates via env.ts<br/>(line 252: NEXT_PUBLIC_APP_URL)
App->>App: Uses in environment.ts<br/>(line 25-26: isHosted check)
2 files reviewed, no comments
|
@sundaram2021 there is already a |
Summary
Brief description of what this PR does and why.
Fixes #(1835)
Type of Change
Testing
How has this been tested? What should reviewers focus on?
Checklist
Screenshots/Videos