Fix/UI Cursor pointer on docs #1975
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oai#1608) * improvement(performance): remove unused source/target indices, add index on snapshot id (simstudioai#1603) * fix(blog): rename building to blogs with redirect (simstudioai#1604) * improvement(privacy-policy): updated privacy policy for google (simstudioai#1602) * updated privacy policy for google * update terms, privacy, and emails to incl address and update verbiage * feat(guardrails): added guardrails block/tools and docs (simstudioai#1605) * Adding guardrails block * ack PR comments * cleanup checkbox in dark mode * cleanup * fix supabase tools * fix(inference-billing): fix inference billing when stream is true via API, add drag-and-drop functionality to deployed chat (simstudioai#1606) * fix(inference): fix inference billing when stream is true via API * add drag-and-drop to deployed chat * feat(mistal): added mistral as a provider, updated model prices (simstudioai#1607) * feat(mistal): added mistral as a provider, updated model prices * remove the ability for a block to reference its own outluts * fixed order of responses for guardrails block * feat(versions): added the ability to rename deployment versions (simstudioai#1610) * fix(vulns): fix various vulnerabilities and enhanced code security (simstudioai#1611) * fix(vulns): fix SSRF vulnerabilities * cleanup * cleanup * regen docs * remove unused deps * fix failing tests * cleanup * update deps * regen bun lock
…ad support for more blocks
…hboard improvements
) * fix(debug-mode): remove duplicate debug mode flag (simstudioai#1714) * feat(i18n): update translations (simstudioai#1709) * improvement(condition): added variable and envvar highlighting for condition input (simstudioai#1718) * fix(dashboard): add additional context for paginated logs in dashboard, add empty state when selected cell has no data (simstudioai#1719) * fix(dashboard): add additional context for paginated logs in dashboard, add empty state when selected cell has no data * apps/sim * renaming * remove relative import * feat(tools): added webflow OAuth + tools (simstudioai#1720) * feat(tools): added webflow OAuth + tools * remove itemId from delete item * remove siteId * added webhook triggers + oauth scopes + site/collection selector * update sample payload for webflow triggers * cleanup * fix discord color * feat(i18n): update translations (simstudioai#1721) * improvement(schedule): fix UI bug with schedule modal (simstudioai#1722)
* fix(already-cancelled-sub): UI should allow restoring subscription * restore functionality fixed * fix
…cp improvements, local kb file storage
* Provider changes * Fix lint
* fix(cmd-k): z-index + reoder tools, triggers * fix more z-index styling
…loy when redeploy is not necessary (simstudioai#1973) * fix(workflow-block): fix redeploy header to not repeatedly show redeploy when redeploy is not necessary * cleanup
…#1974) * improvement(usage-indicator): layout * improvement: expand default terminal height * fix: swap workflow block ports * improvement: chat initial positioning * improvement(chat): display; improvement(emcn): popover attributes
|
@Khanisic is attempting to deploy a commit to the Sim Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Greptile OverviewGreptile SummaryThis PR has significant scope creep - while titled "Fix/UI Cursor pointer on docs", only 3 of 30 files actually relate to cursor pointer styling. The cursor pointer changes themselves add redundant Major Issues:
Recommendations:
Confidence Score: 1/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant UI as UI Components
participant CSS as Browser CSS
participant Files as Other Files
Dev->>UI: Add cursor-pointer to buttons
Note over UI,CSS: cursor-pointer redundant on buttons
CSS-->>UI: Buttons already have pointer cursor
Dev->>Files: Add unrelated changes
Note over Files: 27 of 30 files unrelated to PR
Files->>Files: Terminal height adjustments
Files->>Files: Popover enhancements
Files->>Files: Deployment refactoring
Files->>Files: Brand color updates
Files->>Files: Provider changes
Files->>Files: Store modifications
Dev->>UI: Modify globals.css
Note over UI: Violates custom instruction
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| <button | ||
| onClick={() => setTheme(theme === 'dark' ? 'light' : 'dark')} | ||
| className='flex items-center justify-center rounded-md p-1 text-muted-foreground transition-colors hover:text-foreground' | ||
| className='flex items-center cursor-pointer justify-center rounded-md p-1 text-muted-foreground transition-colors hover:text-foreground' |
Contributor
There was a problem hiding this comment.
style: cursor-pointer is redundant on button elements - browsers already apply cursor: pointer by default
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/docs/components/ui/theme-toggle.tsx
Line: 26:26
Comment:
**style:** `cursor-pointer` is redundant on button elements - browsers already apply `cursor: pointer` by default
How can I resolve this? If you propose a fix, please make it concise.| onClick={() => setOpen(!open)} | ||
| className={cn( | ||
| 'flex w-full items-center justify-between rounded-md px-2.5 py-1.5 text-left font-medium text-[13px] leading-tight transition-colors', | ||
| 'cursor-pointer flex w-full items-center justify-between rounded-md px-2.5 py-1.5 text-left font-medium text-[13px] leading-tight transition-colors', |
Contributor
There was a problem hiding this comment.
style: cursor-pointer is redundant on button elements - browsers already apply cursor: pointer by default
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/docs/components/docs-layout/sidebar-components.tsx
Line: 87:87
Comment:
**style:** `cursor-pointer` is redundant on button elements - browsers already apply `cursor: pointer` by default
How can I resolve this? If you propose a fix, please make it concise.| aria-expanded={isOpen} | ||
| aria-controls='language-menu' | ||
| className='flex items-center gap-1.5 rounded-xl px-3 py-2 font-normal text-[0.9375rem] text-foreground/60 leading-[1.4] transition-colors hover:bg-foreground/8 hover:text-foreground focus:outline-none focus-visible:ring-2 focus-visible:ring-ring' | ||
| className='cursor-pointer flex items-center gap-1.5 rounded-xl px-3 py-2 font-normal text-[0.9375rem] text-foreground/60 leading-[1.4] transition-colors hover:bg-foreground/8 hover:text-foreground focus:outline-none focus-visible:ring-2 focus-visible:ring-ring' |
Contributor
There was a problem hiding this comment.
style: cursor-pointer is redundant on button elements - browsers already apply cursor: pointer by default
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/docs/components/ui/language-dropdown.tsx
Line: 85:85
Comment:
**style:** `cursor-pointer` is redundant on button elements - browsers already apply `cursor: pointer` by default
How can I resolve this? If you propose a fix, please make it concise.| role='option' | ||
| aria-selected={currentLang === code} | ||
| className={`flex w-full items-center gap-3 px-3 py-3 text-base transition-colors first:rounded-t-xl last:rounded-b-xl hover:bg-muted/80 focus:outline-none focus-visible:ring-2 focus-visible:ring-ring md:gap-2 md:px-2.5 md:py-2 md:text-sm ${ | ||
| className={`cursor-pointer flex w-full items-center gap-3 px-3 py-3 text-base transition-colors first:rounded-t-xl last:rounded-b-xl hover:bg-muted/80 focus:outline-none focus-visible:ring-2 focus-visible:ring-ring md:gap-2 md:px-2.5 md:py-2 md:text-sm ${ |
Contributor
There was a problem hiding this comment.
style: cursor-pointer is redundant on button elements - browsers already apply cursor: pointer by default
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/docs/components/ui/language-dropdown.tsx
Line: 113:113
Comment:
**style:** `cursor-pointer` is redundant on button elements - browsers already apply `cursor: pointer` by default
How can I resolve this? If you propose a fix, please make it concise.| --toolbar-triggers-height: 300px; | ||
| --editor-connections-height: 200px; | ||
| --terminal-height: 145px; | ||
| --terminal-height: 196px; |
Contributor
There was a problem hiding this comment.
logic: violates the project's custom instruction which states: "Avoid editing the globals.css file unless absolutely necessary. Move style changes to local component files instead."
this terminal height change is unrelated to the cursor pointer fix described in the PR title and description
Suggested change
| --terminal-height: 196px; | |
| --terminal-height: 145px; |
Context Used: Context from dashboard - Avoid editing the globals.css file unless absolutely necessary. Move style changes to local componen... (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/app/globals.css
Line: 14:14
Comment:
**logic:** violates the project's custom instruction which states: "Avoid editing the `globals.css` file unless absolutely necessary. Move style changes to local component files instead."
this terminal height change is unrelated to the cursor pointer fix described in the PR title and description
```suggestion
--terminal-height: 145px;
```
**Context Used:** Context from `dashboard` - Avoid editing the globals.css file unless absolutely necessary. Move style changes to local componen... ([source](https://app.greptile.com/review/custom-context?memory=c3b5e4b0-6580-4307-83aa-ba28f105b3c4))
How can I resolve this? If you propose a fix, please make it concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds cursor pointer styling to improve clarity and interactivity across key UI elements.
Specifically, cursor pointer has been added to:
• the theme toggler in the navbar
• sidebar navigation buttons
• the language selector button in the navbar
These elements are all interactive, so adding proper pointer feedback improves usability and aligns with standard UI behavior.
Type of Change
Testing
Confirmed that the cursor changes to the correct pointer type on hover.
Checklist
Screenshots/Videos