-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Fix/UI Cursor pointer on docs #1975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
219a065
7f82ed3
fb0fa1f
2bc8c7b
04f109c
da091df
e4ddeb0
641e353
9751c9f
1b7437a
71ae27b
9b2490c
7f1ff7f
a02016e
9a4b9e2
a70f2a6
383b6f0
3a8f01f
6f4f8cf
b67b4ff
80eaeb0
32a2e09
e860449
2d7d913
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -82,7 +82,7 @@ export function LanguageDropdown() { | |
| aria-haspopup='listbox' | ||
| aria-expanded={isOpen} | ||
| aria-controls='language-menu' | ||
| className='flex items-center gap-1.5 rounded-xl px-3 py-2 font-normal text-[0.9375rem] text-foreground/60 leading-[1.4] transition-colors hover:bg-foreground/8 hover:text-foreground focus:outline-none focus-visible:ring-2 focus-visible:ring-ring' | ||
| className='cursor-pointer flex items-center gap-1.5 rounded-xl px-3 py-2 font-normal text-[0.9375rem] text-foreground/60 leading-[1.4] transition-colors hover:bg-foreground/8 hover:text-foreground focus:outline-none focus-visible:ring-2 focus-visible:ring-ring' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. style: Prompt To Fix With AIThis is a comment left during a code review.
Path: apps/docs/components/ui/language-dropdown.tsx
Line: 85:85
Comment:
**style:** `cursor-pointer` is redundant on button elements - browsers already apply `cursor: pointer` by default
How can I resolve this? If you propose a fix, please make it concise. |
||
| style={{ | ||
| fontFamily: | ||
| '-apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, sans-serif', | ||
|
|
@@ -110,7 +110,7 @@ export function LanguageDropdown() { | |
| }} | ||
| role='option' | ||
| aria-selected={currentLang === code} | ||
| className={`flex w-full items-center gap-3 px-3 py-3 text-base transition-colors first:rounded-t-xl last:rounded-b-xl hover:bg-muted/80 focus:outline-none focus-visible:ring-2 focus-visible:ring-ring md:gap-2 md:px-2.5 md:py-2 md:text-sm ${ | ||
| className={`cursor-pointer flex w-full items-center gap-3 px-3 py-3 text-base transition-colors first:rounded-t-xl last:rounded-b-xl hover:bg-muted/80 focus:outline-none focus-visible:ring-2 focus-visible:ring-ring md:gap-2 md:px-2.5 md:py-2 md:text-sm ${ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. style: Prompt To Fix With AIThis is a comment left during a code review.
Path: apps/docs/components/ui/language-dropdown.tsx
Line: 113:113
Comment:
**style:** `cursor-pointer` is redundant on button elements - browsers already apply `cursor: pointer` by default
How can I resolve this? If you propose a fix, please make it concise. |
||
| currentLang === code ? 'bg-muted/60 font-medium text-primary' : 'text-foreground' | ||
| }`} | ||
| > | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,7 @@ export function ThemeToggle() { | |
| return ( | ||
| <button | ||
| onClick={() => setTheme(theme === 'dark' ? 'light' : 'dark')} | ||
| className='flex items-center justify-center rounded-md p-1 text-muted-foreground transition-colors hover:text-foreground' | ||
| className='flex items-center cursor-pointer justify-center rounded-md p-1 text-muted-foreground transition-colors hover:text-foreground' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. style: Prompt To Fix With AIThis is a comment left during a code review.
Path: apps/docs/components/ui/theme-toggle.tsx
Line: 26:26
Comment:
**style:** `cursor-pointer` is redundant on button elements - browsers already apply `cursor: pointer` by default
How can I resolve this? If you propose a fix, please make it concise. |
||
| aria-label='Toggle theme' | ||
| > | ||
| {theme === 'dark' ? <Moon className='h-4 w-4' /> : <Sun className='h-4 w-4' />} | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -11,7 +11,7 @@ | |||||
| --panel-width: 244px; | ||||||
| --toolbar-triggers-height: 300px; | ||||||
| --editor-connections-height: 200px; | ||||||
| --terminal-height: 145px; | ||||||
| --terminal-height: 196px; | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. logic: violates the project's custom instruction which states: "Avoid editing the this terminal height change is unrelated to the cursor pointer fix described in the PR title and description
Suggested change
Context Used: Context from Prompt To Fix With AIThis is a comment left during a code review.
Path: apps/sim/app/globals.css
Line: 14:14
Comment:
**logic:** violates the project's custom instruction which states: "Avoid editing the `globals.css` file unless absolutely necessary. Move style changes to local component files instead."
this terminal height change is unrelated to the cursor pointer fix described in the PR title and description
```suggestion
--terminal-height: 145px;
```
**Context Used:** Context from `dashboard` - Avoid editing the globals.css file unless absolutely necessary. Move style changes to local componen... ([source](https://app.greptile.com/review/custom-context?memory=c3b5e4b0-6580-4307-83aa-ba28f105b3c4))
How can I resolve this? If you propose a fix, please make it concise. |
||||||
| } | ||||||
|
|
||||||
| .sidebar-container { | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style:
cursor-pointeris redundant on button elements - browsers already applycursor: pointerby defaultPrompt To Fix With AI