if we have multiple SSRC in one stream, the REMB feedback comes in for ssrc 0, #1472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if we have multiple SSRC in one stream, the REMB feedback comes in for ssrc 0, the real Feedback-SSRCs are in the FeedbackSSRCs array and need to be matched by user.
weltmeyer
changed the title
use Pattern matching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if we have multiple SSRC in one stream, the REMB feedback comes in for ssrc 0, the real Feedback-SSRCs are in the FeedbackSSRCs array and need to be matched by user.
Because of this we should not stop search MediaSDtream when GetMediaStream for RR is null or for Feedback is null (SSRC wont match as it is 0)
we can still continue to search for the matching SSRC in first Stream below.