Skip to content

if we have multiple SSRC in one stream, the REMB feedback comes in for ssrc 0, #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

if we have multiple SSRC in one stream, the REMB feedback comes in for ssrc 0, #1472

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad43122
Update RTPSession.cs
weltmeyer Oct 22, 2025
7a806c3
Update RTPSession.cs
weltmeyer Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/net/RTP/RTPSession.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2696,13 +2696,19 @@ private MediaStream GetMediaStream(RTCPCompoundPacket rtcpPkt)
{
return GetMediaStream(rtcpPkt.SenderReport.SSRC);
}
else if (rtcpPkt.ReceiverReport != null)
else if (rtcpPkt.ReceiverReport is { } receiverReport)
{
return GetMediaStream(rtcpPkt.ReceiverReport.SSRC);
if (GetMediaStream(receiverReport.SSRC) is { } mediaStream)
{
return mediaStream;
}
}
else if (rtcpPkt.Feedback != null)
else if (rtcpPkt.Feedback is { } feedback)
{
return GetMediaStream(rtcpPkt.Feedback.SenderSSRC);
if (GetMediaStream(feedback.SenderSSRC) is { } mediaStream)
{
return mediaStream;
}
}
else if (rtcpPkt.TWCCFeedback != null)
{
Expand Down