feat: add user-defined command aliases via ~/.bernstein/aliases.yaml#265
Closed
TheCodingDragon0 wants to merge 2 commits into
Closed
feat: add user-defined command aliases via ~/.bernstein/aliases.yaml#265TheCodingDragon0 wants to merge 2 commits into
TheCodingDragon0 wants to merge 2 commits into
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Reviewed by grok-code-fast-1 · 93,256 tokens |
chernistry
requested changes
Apr 6, 2026
chernistry
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! Same Pyright strict-mode issues as #264 since this touches the same aliases.py file:
- Line 64 —
yaml.safe_load()returnsAny. Usedata: object = yaml.safe_load(f) or {} - Line 67 — unknown
k/vtypes. Narrow the dict first:raw = data if isinstance(data, dict) else {} - Line 76 —
_USER_ALIASESuppercase = constant in Pyright. Rename to_user_aliases
See my review on #264 for full code snippets.
|
Collaborator
|
Already merged as part of #264 — thanks! |
Contributor
Author
This was referenced Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #249
Extended the alias system to support user-defined aliases loaded from ~/.bernstein/aliases.yaml. User aliases override built-in ones. The �ernstein aliases command now shows whether each alias is built-in or user-defined.
Changes: