Implement six-date #340
Open
Implement six-date #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidemarcoli
requested review from
ibirrer and
colinscz
and removed request for
ibirrer
ibirrer
reviewed
Mar 26, 2025
libraries/ui-library/src/components/six-date/six-date-formats.ts
Outdated
Show resolved
Hide resolved
libraries/ui-library/src/components/six-date/components/year-selection.tsx
Outdated
Show resolved
Hide resolved
libraries/ui-library-vue/src/lib/stencil-generated/vue-component-lib/utils.ts
Outdated
Show resolved
Hide resolved
davidemarcoli
force-pushed
the
feature/six-date
branch
from
e9b6b4a to
e7954df
Compare
ibirrer
force-pushed
the
feature/six-date
branch
2 times, most recently
from
af8d3f0 to
2a8b091
Compare
ibirrer
force-pushed
the
feature/six-date
branch
from
2a8b091 to
fd7fa4b
Compare
JoelLeupp
previously approved these changes
Apr 23, 2025
|
|
||
| render() { | ||
| return ( | ||
| <div class="container"> |
There was a problem hiding this comment.
I would add ARIA attributes like role and data-testid to make the component more accessible
There was a problem hiding this comment.
What aria role would be approriate here?
ibirrer
force-pushed
the
feature/six-date
branch
from
fd7fa4b to
2c68f5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
six-datecomponent as a simplified replacement for the existingsix-datepicker.The six-datepicker has grown complex over time, with features that are hard to maintain and inconsistent in usage. Key motivations for a fresh start: