Skip to content

Conversation

@Phu2
Copy link
Contributor

@Phu2 Phu2 commented Oct 1, 2025

Resolves #326

@Phu2 Phu2 requested a review from sroertgen October 1, 2025 15:34
@Phu2 Phu2 self-assigned this Oct 1, 2025
@Phu2
Copy link
Contributor Author

Phu2 commented Oct 1, 2025

@sroertgen How do you publish a new image on Docker Hub?

I'd like to rebuild a vocabulary on our test server for the functional review. Our webhook test instance uses the skohub/skohub-vocabs-docker:dev image for building the vocabulary. Therefore i wanted to publish this branch to Docker Hub. However, i am not sure if this is even the right approach or workflow.

@Phu2 Phu2 force-pushed the 29-footer-links branch from 29a0897 to c4fb0a9 Compare October 2, 2025 07:49
@acka47
Copy link
Member

acka47 commented Oct 2, 2025

However, i am not sure if this is even the right approach or workflow.

The usual approach:

  1. We merge feature branches into the dev branch.
  2. This triggers a rebuild of test.skohub.io based on the dev branch.
  3. Usually, I am the one to test new features. If needed I adjust/add vocabs in https://github.com/acka47/testing-skohub-vocabs and then trigger a build on test.skohub.io to do the functional review.
  4. If needed, adustments are made in the feature branch and back to 1.).
  5. If I approve the changes, the feature branch is merged into main.

Example: Recently, I merged a feature branch into dev, see #318 (comment). I then triggered the webhook, see https://test.skohub.io/build?id=955b3a73-062f-4a70-890c-6eba29ca92eb, and, voilà, we have some new information in the HTML for the vocabulary: https://test.skohub.io/acka47/testing-skohub-vocabs/heads/master/w3id.org/kim/hcrt/scheme.html

@Phu2
Copy link
Contributor Author

Phu2 commented Oct 2, 2025

Thanks. I will merge into dev.

@Phu2
Copy link
Contributor Author

Phu2 commented Oct 2, 2025

@acka47 see https://test.skohub.io/sroertgen/test-vocabs/heads/main/ for an example of the new configurable footer links.

@Phu2 Phu2 requested review from acka47 and removed request for sroertgen October 6, 2025 07:35
Copy link
Member

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Also tried it out with config.yaml & some adjustments:

However, documentation is missing in the UI config section in README.md which hinders me from giving a final +1

@Phu2 Phu2 requested a review from acka47 October 6, 2025 13:45
Copy link
Member

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Phu2 Phu2 requested a review from sroertgen October 6, 2025 14:37
@Phu2
Copy link
Contributor Author

Phu2 commented Oct 6, 2025

Assigning @sroertgen for code review

Removed commented-out console log for config.
@Phu2 Phu2 merged commit 925a578 into main Nov 21, 2025
3 checks passed
@Phu2 Phu2 deleted the 29-footer-links branch November 21, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Further customizability concerning impressum and licence

4 participants