300 sortable searchable schemes #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add tests for that info
Only show vocabs if number of concept schemes is greater than 4
Member
|
Merged into dev for functional review: f8c756a |
acka47
added a commit
to acka47/testing-skohub-vocabs
that referenced
this pull request
Oct 6, 2025
...for testing skohub-io/skohub-vocabs#331
Phu2
approved these changes
Oct 7, 2025
acka47
approved these changes
Oct 7, 2025
Member
acka47
left a comment
acka47
left a comment
There was a problem hiding this comment.
+1 Looks good to me. It also works when searching with Umlauts or for parts of a word.
I am not so sure about the threshold, though. I tested it with seven vocabs, see https://test.skohub.io/acka47/testing-skohub-vocabs/heads/master/, and it still felt like the search is too much. As the search bar does not look out-of-place as soon as there are some vocabs, we can leave it like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add search field as requested in #300