Adding a special case to _common so that Data Ops get a more informative message#1607
Merged
jeromedockes merged 7 commits intoSep 19, 2025
Merged
Conversation
| dop = [skrub.var("a")] * n_params | ||
| with pytest.raises( | ||
| TypeError, | ||
| match=r"Operation not supported on DataOps.*Expecting a Pandas*", |
Co-authored-by: Gael Varoquaux <gael.varoquaux@normalesup.org>
Co-authored-by: Jérôme Dockès <jerome@dockes.org>
rcap107
added a commit
to rcap107/skrub
that referenced
this pull request
Sep 25, 2025
rcap107
added a commit
that referenced
this pull request
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a check to the dispatch module so that if it gets passed a Data Op a more specific error message is shown.
This should address #1477
With this,
gets the message