-
Notifications
You must be signed in to change notification settings - Fork 261
Adding a special case to _common so that Data Ops get a more informative message #1607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jeromedockes
merged 7 commits into
skrub-data:main
from
rcap107:dop-better-error-message-dispatch
Sep 19, 2025
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4f4ae77
adding check on type
rcap107 8687783
changelog
rcap107 db659eb
Apply suggestions from code review
rcap107 d6f55a5
fixing test
rcap107 e0ff048
reworking message
rcap107 029fd5f
Update skrub/_dataframe/_common.py
rcap107 054a55c
Merge branch 'main' into dop-better-error-message-dispatch
rcap107 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,7 @@ | |
| from numpy.testing import assert_array_equal | ||
| from pandas.testing import assert_frame_equal as pd_assert_frame_equal | ||
|
|
||
| import skrub | ||
| from skrub import selectors as s | ||
| from skrub._dataframe import _common as ns | ||
|
|
||
|
|
@@ -40,6 +41,12 @@ def test_not_implemented(): | |
| params = [None] * n_params | ||
| with pytest.raises(TypeError): | ||
| func(*params) | ||
| dop = [skrub.var("a")] * n_params | ||
| with pytest.raises( | ||
| TypeError, | ||
| match=r"Operation not supported on DataOps.*Expecting a Pandas*", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Need to change this :) |
||
| ): | ||
| func(*dop) | ||
|
|
||
|
|
||
| # | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.