Fix pyarrow missing module when using ToDatetime with polars dataframe#1645
Merged
Merged
Conversation
jeromedockes
reviewed
Oct 2, 2025
jeromedockes
left a comment
jeromedockes
left a comment
Member
There was a problem hiding this comment.
thanks a lot @MarieSacksick !
apart from the small nitpick LGTM :)
Co-authored-by: Jérôme Dockès <jerome@dockes.org>
This was referenced Oct 2, 2025
jeromedockes
reviewed
Oct 2, 2025
jeromedockes
approved these changes
Oct 2, 2025
Member
|
Thank you very much @MarieSacksick !! the coverage missed line is expected and will be tackled in #1648 LGTM |
dierickxsimon
pushed a commit
to dierickxsimon/skrub
that referenced
this pull request
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfixing the pyarrow missing import.
tested in local.
Will try to do another PR to add a CI about it.