Skip to content

Fix pyarrow missing module when using ToDatetime with polars dataframe #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeromedockes merged 3 commits into from
Oct 2, 2025
Merged

Fix pyarrow missing module when using ToDatetime with polars dataframe #1645

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4a0e1e
Bugfix https://github.com/skrub-data/skrub/issues/1640
MarieSacksick Oct 2, 2025
e08efdf
Update skrub/_dataframe/_common.py
MarieSacksick Oct 2, 2025
4397c6e
Update skrub/_dataframe/_common.py
jeromedockes Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion skrub/_dataframe/_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,11 +265,22 @@ def _to_pandas_pandas(obj):
return obj


@to_pandas.specialize("polars")
@to_pandas.specialize("polars", argument_type="DataFrame")
def _to_pandas_polars(obj):
return obj.to_pandas()


@to_pandas.specialize("polars", argument_type="Column")
def _to_pandas_polars_column(obj):
"""Convert a polars Series to a pandas Series, through numpy when pyarrow is not
installed."""
try:
return obj.to_pandas()
except ImportError:
Comment thread
jeromedockes marked this conversation as resolved.
# pyarrow is needed for polars .to_pandas() and may not be installed
return pd.Series(to_numpy(obj))


@dispatch
def make_dataframe_like(obj, data):
"""Create a dataframe from `data` using the module of `obj`.
Expand Down