Update Spell Crafter Workflow #52
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amusingaxl
reviewed
Oct 3, 2025
amusingaxl
reviewed
Oct 3, 2025
| * [ ] Test new ilk registry values | ||
| * [ ] Test new ChainLog values | ||
| * [ ] Test DAI/MKR streams and payments, lerps | ||
| * [ ] Test SKY streams and payments |
There was a problem hiding this comment.
Update the check above replacing DAI with USDS and MKR with SKY.
There was a problem hiding this comment.
Addressed in ddea55c
There was a problem hiding this comment.
What I meant is that you could remove this like.
Suggested change
| * [ ] Test SKY streams and payments |
amusingaxl
reviewed
Oct 3, 2025
| * [ ] Make sure generated hash matches with the hash provided from Governance Facilitator, OTHERWISE notify Responsible Governance Facilitator | ||
| * [ ] Ensure that executive vote file name and date is correct | ||
| * [ ] [community](https://github.com/makerdao/community) repo commit hash corresponds to latest change | ||
| * [ ] [community](https://github.com/sky-ecosystem/community) repo commit hash corresponds to latest change |
There was a problem hiding this comment.
You can remove this one. New spells will always be in the executive-votes repo
There was a problem hiding this comment.
Addressed in ddea55c
amusingaxl
reviewed
Oct 3, 2025
| * [ ] IF there is no local copy of [`sky-ecosystem/community` GitHub repo](https://github.com/sky-ecosystem/community), run: | ||
| ``` | ||
| git clone https://github.com/makerdao/community | ||
| git clone https://github.com/sky-ecosystem/community |
There was a problem hiding this comment.
Likewise, you can remove this one.
There was a problem hiding this comment.
Addressed in ddea55c
riccardopersiani
requested review from
SidestreamColdMelon,
SidestreamStrongStrawberry and
amusingaxl
amusingaxl
reviewed
Oct 7, 2025
Comment on lines
38
to
39
| * [ ] Find the first [Foundry release](https://github.com/foundry-rs/foundry/releases) that is older than 7 days from now | ||
| * [ ] Insert the release URL here: |
There was a problem hiding this comment.
Remove these lines:
Suggested change
| * [ ] Find the first [Foundry release](https://github.com/foundry-rs/foundry/releases) that is older than 7 days from now | |
| * [ ] Insert the release URL here: |
There was a problem hiding this comment.
Added this suggestion in the SideStream PR.
|
Closing as #54 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📯 Updates:
)typo.