Refresh the checklists to match latest practices #54

SidestreamBurningBanana · 2025-10-08T08:41:13Z

This PR applies several changes to the checklists in order to make them up-to-date.

Context: It has been opened to be used as a comparing point towards #52 and #53. The PR contents itself have been independently developed internally in September.

Differences from #52 and #53

Missing in this PR

Note: items marked with ✅ have been added to this PR.

✅ Foundry installation instructions have been changed:

pe-checklists/spell/spell-crafter-mainnet-workflow.md

Line 40 in 7cb1544

* [ ] Install the specified version via `foundryup --install stable`

pe-checklists/spell/spell-reviewer-mainnet-checklist.md

Line 10 in 7b03757

* [ ] Install the specified version via `foundryup --install stable`
Fetch addresses as type address item has been removed: https://github.com/sky-ecosystem/pe-checklists/pull/52/files#diff-fa1cbbb341c9d0c8abfea5082cffca265ac7f5e983b53c971d2e214bf731c155L115
✅ Test name has been changed:

pe-checklists/spell/spell-crafter-mainnet-workflow.md

Line 125 in 7cb1544

* [ ] Additions are tested via `testAddedChainlogKeys`
✅ There was a repo link added to reviewer checklist:

pe-checklists/spell/spell-reviewer-mainnet-checklist.md

Line 3 in 7b03757

Repo: https://github.com/sky-ecosystem/spells-mainnet
✅ ether comment has been changed:

pe-checklists/spell/spell-reviewer-mainnet-checklist.md

Line 202 in 7b03757

* [ ] IF `ether` keyword is used, comment is present on the same line `// Note: ether is a keyword that represents 10**18, not the ETH token`
✅ Test has been added:

pe-checklists/spell/spell-reviewer-mainnet-checklist.md

Line 284 in 7b03757

* [ ] Changes are tested via `testChainlogIntegrity` and `testChainlogValues` and `testAddedChainlogKeys`

Added in this PR

Commit order re-organized to match the actual flow:

pe-checklists/spell/spell-crafter-mainnet-workflow.md

Line 69 in a85c611

* [ ] Commit the cleanup (e.g. `git commit -am "Base spell"`)

pe-checklists/spell/spell-crafter-mainnet-workflow.md

Line 86 in a85c611

* [ ] Push the local changes

pe-checklists/spell/spell-crafter-mainnet-workflow.md

Line 89 in a85c611

* [ ] CI tests PASS

All possible tokens are mentioned for crafter:

pe-checklists/spell/spell-crafter-mainnet-workflow.md

Lines 134 to 135 in a85c611

    
             * [ ] Test DAI/MKR/USDS/SKY/SPK streams and payments, lerps 
        
             * [ ] Test the sum of all DAI/MKR/USDS/SKY/SPK payments matches the Exec Sheet

Proof URL rule extended to include https check:

pe-checklists/spell/spell-reviewer-mainnet-checklist.md

Lines 32 to 40 in a85c611

    
             * Every proof url from the Exec Sheet, such as `Reasoning URL` and `Authority URL`: 
        
               * [ ] Is present in the spell code under relevant section or instruction (depending on which row the url is present) 
        
               * [ ] Has the `https` scheme 
        
               * [ ] Has prefix derived from the url itself 
        
                 * `// Executive Vote:` if URL starts with `https://vote.sky.money/executive/` 
        
                 * `// Poll:` if URL starts with `https://vote.sky.money/polling/` 
        
                 * `// Forum:` if URL starts with `https://forum.sky.money/t/` 
        
                 * `// MIP:` if URL starts with `https://mips.makerdao.com/mips/details/` 
        
                 * `// Atlas:` if URL starts with `https://sky-atlas.powerhouse.io/`

Single import layout rule changed:

pe-checklists/spell/spell-reviewer-mainnet-checklist.md

Line 52 in a85c611

* [ ] Only single import layout is used (e.g. `import { VatAbstract } from "dss-interfaces/dss/VatAbstract.sol";`)

All possible tokens are mentioned for reviewer:

pe-checklists/spell/spell-reviewer-mainnet-checklist.md

Lines 197 to 227 in a85c611

    
             * IF `MKR` transfers are present 
        
               * [ ] Recipient address in the instruction is in the checksummed format 
        
               * [ ] Recipient address matches Exec Sheet 
        
               * [ ] Recipient address variable name matches one found in `addresses_wallets.sol` 
        
               * [ ] Transfer amount matches Exec Sheet 
        
               * [ ] Transfer amount is specified with (at least) 2 decimals using `ether` keyword 
        
               * [ ] IF `ether` keyword is used, comment is present on the same line `// Note: ether is a keyword helper, only MKR is transferred here` 
        
               * [ ] The transfers are tested via `testPayments` test 
        
               * [ ] Sum of all MKR transfers tested in `testPayments` matches number in the Exec Sheet 
        
             * IF `SKY` transfers are present 
        
               * [ ] Recipient address in the instruction is in the checksummed format 
        
               * [ ] Recipient address matches Exec Sheet 
        
               * [ ] Recipient address variable name matches one found in `addresses_wallets.sol` 
        
               * [ ] Transfer amount matches Exec Sheet 
        
               * [ ] The transfers are tested via `testPayments` test 
        
               * [ ] Sum of all SKY transfers tested in `testPayments` matches number in the Exec Sheet 
        
             * IF `DAI` surplus buffer transfers are present 
        
               * [ ] Recipient address in the instruction is in the checksummed format 
        
               * [ ] Recipient address matches Exec Sheet 
        
               * [ ] Recipient address variable name matches one found in `addresses_wallets.sol` 
        
               * [ ] Transfer amount matches Exec Sheet 
        
               * [ ] The transfers are tested via `testPayments` test 
        
               * [ ] Sum of all DAI transfers tested in `testPayments` matches number in the Exec Sheet 
        
             * IF `USDS` surplus buffer transfers are present 
        
               * [ ] Recipient address in the instruction is in the checksummed format 
        
               * [ ] Recipient address matches Exec Sheet 
        
               * [ ] Recipient address variable name matches one found in `addresses_wallets.sol` 
        
               * [ ] Transfer amount matches Exec Sheet 
        
               * [ ] The transfers are tested via `testPayments` test 
        
               * [ ] Sum of all USDS transfers tested in `testPayments` matches number in the Exec Sheet 
        
             * IF `MKR` / `DAI` / `SKY` / `USDS` / `SPK` streams (`DssVest`) are created

pe-checklists/spell/spell-reviewer-mainnet-checklist.md

Lines 253 to 282 in a85c611

    
               * IF MKR stream ([DssVestTransferrable](https://github.com/sky-ecosystem/dss-vest/blob/master/src/DssVest.sol#L463)) is present 
        
                 * [ ] Vest contract's MKR allowance increased by the cumulative `total` (the sum of all `tot` values) 
        
                 * [ ] Ensure allowance increase follows archive patterns 
        
               * IF SKY stream ([DssVestTransferrable](https://github.com/sky-ecosystem/dss-vest/blob/master/src/DssVest.sol#L463)) is present 
        
                 * [ ] Vest contract's SKY allowance increased by the cumulative `total` (the sum of all `tot` values) 
        
                 * [ ] Ensure allowance increase follows archive patterns 
        
               * IF SPK stream ([DssVestTransferrable](https://github.com/sky-ecosystem/dss-vest/blob/master/src/DssVest.sol#L463)) is present 
        
                 * [ ] Vest contract's SPK allowance increased by the cumulative `total` (the sum of all `tot` values) 
        
                 * [ ] Ensure allowance increase follows archive patterns 
        
               * [ ] Tested via: 
        
                 * `testVestDai` 
        
                 * `testVestMkr` 
        
                 * `testVestSky` 
        
                 * `testVestSkyMint` 
        
                 * `testVestUsds` 
        
                 * `testVestSpk` 
        
             * IF `MKR` / `DAI` / `SKY` / `USDS` / `SPK` vest termination (`Yank`) is present 
        
               * [ ] Yanked stream ID matches Exec Sheet 
        
               * [ ] `MCD_VEST_MKR_TREASURY` chainlog address is used for MKR stream `yank` 
        
               * [ ] `MCD_VEST_SKY_TREASURY` chainlog address is used for SKY stream `yank` 
        
               * [ ] `MCD_VEST_SPK_TREASURY` chainlog address is used for SPK stream `yank` 
        
               * [ ] `MCD_VEST_DAI` chainlog address is used for DAI stream `yank` 
        
               * [ ] `MCD_VEST_USDS` chainlog address is used for USDS stream `yank` 
        
               * [ ] Tested via: 
        
                 * `testYankDAI` 
        
                 * `testYankMKR` 
        
                 * `testYankSky` 
        
                 * `testYankSkyMint` 
        
                 * `testYankUsds` 
        
                 * `testYankSpk`

tau error is fixed:

pe-checklists/spell/spell-reviewer-mainnet-checklist.md

Line 237 in a85c611

* [ ] `tau` is expressed as `fin - bgn` (i.e. `MONTH_DD_YYYY - MONTH_DD_YYYY`)
Code actuality check is added:

pe-checklists/spell/spell-reviewer-mainnet-checklist.md

Line 404 in a85c611

* [ ] Ensure local code is up-to-date with the remote branch (e.g. `git pull`)
"Good to Handover" item is added:

pe-checklists/spell/spell-reviewer-mainnet-checklist.md

Line 436 in a85c611

* [ ] Publish an explicit "good to handover" comment

amusingaxl · 2025-10-08T13:29:26Z

spell/spell-crafter-mainnet-workflow.md

+  * [ ] Test DAI/MKR/USDS/SKY/SPK streams and payments, lerps
+  * [ ] Test the sum of all DAI/MKR/USDS/SKY/SPK payments matches the Exec Sheet


I believe it's safe to say that we can remove DAI and MKR mentions here.

I believe that both DAI and MKR, while not recently used in payments or streams, are still owned by the protocol. In case of DAI, it is still used under the hood of several things (like transferUsds).

Keeping them in seems like a zero-effort and no-compromise solution to me as they can be ignored unless required.

I would also be fine with removing only MKR as it is now officially retired and there is practically zero chance of getting new MKR payments or streams.

There will be no DAI or MKR payments/vesting streams in the future. Since we're making the effort to update the checklist, I'd say we should simply remove mentions to it.

Also notice that sendPaymentFromSurplusBuffer will support USDS in the next release of DssExecLib.

amusingaxl · 2025-10-08T13:33:54Z

spell/spell-reviewer-mainnet-checklist.md

  * Interfaces imported from `dss-interfaces`
    * [ ] No unused `dss-interfaces`
-    * [ ] Only single import layout is used (e.g. `import "dss-interfaces/dss/VatAbstract.sol";`)
+    * [ ] Only single import layout is used (e.g. `import { VatAbstract } from "dss-interfaces/dss/VatAbstract.sol";`)


There are 744 matches in the archive with named imports WITHOUT spaces, while there are 254 examples of imports WITH spaces.

forge fmt by default formats imports without spaces, even though we still don't use it in this repo.

Suggested change

* [ ] Only single import layout is used (e.g. `import { VatAbstract } from "dss-interfaces/dss/VatAbstract.sol";`)

* [ ] Only single import layout is used (e.g. `import {VatAbstract} from "dss-interfaces/dss/VatAbstract.sol";`)

amusingaxl · 2025-10-08T15:01:32Z

spell/spell-reviewer-mainnet-checklist.md

    * [ ] IF vest amount is expressed in 'per year' or similar in the Exec Sheet, account for leap days
    * [ ] `bgn` (Vest start timestamp) matches Exec Sheet
-    * [ ] `tau` is expressed as `bgn - fin` (i.e. `MONTH_DD_YYYY - MONTH_DD_YYYY`)
+    * [ ] `tau` is expressed as `fin - bgn` (i.e. `MONTH_DD_YYYY - MONTH_DD_YYYY`)


That's not always the case.
This item was included back when Core Units were paid by streams with predefined bgn and fin, but more recently the most common use cases for vesting streams are the farms.
Usually tau is expressed as an interval in such cases.

You are right, I can mention both formats as acceptable since both seem to be used:

fin - bgn: https://github.com/sky-ecosystem/spells-mainnet/blob/fd9dbf23a5b6724b7367b6d4024b8d983743a796/archive/2025-01-23-DssSpell/DssSpell.sol#L240

exact time: https://github.com/sky-ecosystem/spells-mainnet/blob/fd9dbf23a5b6724b7367b6d4024b8d983743a796/archive/2025-05-29-DssSpell/DssSpell.sol#L222

amusingaxl · 2025-10-08T15:02:38Z

spell/spell-reviewer-mainnet-checklist.md

+    * [ ] Tested via:
+      * `testYankDAI`
+      * `testYankMKR`
+      * `testYankSky`
+      * `testYankSkyMint`
+      * `testYankUsds`
+      * `testYankSpk`


This was recently refactored. Now both creations and yanks are handled by the testVest{TOKEN} tests.

amusingaxl

I believe we should remove anything related to DAI/MKR payments/vests from the checklists.

riccardopersiani · 2025-10-09T13:33:50Z

spell/spell-crafter-mainnet-workflow.md

    * [ ] Check if oracle deployment is required (e.g. univ3-lp-oracle, new ilk pip, ...) with responsible ecosystem actor
  * IF addresses are used in the spell
    * [ ] Use `immutable` visibility when declaring addresses using `DssExecLib.getChangelogAddress`, OTHERWISE use `constant` for statically defined addresses
    * [ ] Fetch addresses as type `address` and wrap with `Like` suffix interfaces inline (when making calls), EXCEPT `MKR` and vesting contracts


I think we should remove this, or at least remove the exception?

riccardopersiani · 2025-10-09T13:43:11Z

spell/spell-crafter-mainnet-workflow.md

 ## Development Stage

 * Install stable Foundry version
  * [ ] Find the first [Foundry release](https://github.com/foundry-rs/foundry/releases) that is older than 7 days from now


Suggested change

* [ ] Find the first [Foundry release](https://github.com/foundry-rs/foundry/releases) that is older than 7 days from now

With Amusing, we were considering removing this line and the next one.

SidestreamBurningBanana · 2025-10-13T13:47:47Z

DAI/MKR payments/vests

I have removed MKR mentions from the checklists. Unfortunately, there are still several DAI vests with unpaid amounts (e.g. IDs 30-32). I don't have enough context to assume that they will never be Yanked (they have fin set to Sat May 23 11:59:59 PM UTC 2026).

If it's fine with you, I'd prefer to keep DAI in the checklists for now.

amusingaxl · 2025-10-13T18:33:23Z

spell/spell-reviewer-mainnet-checklist.md

  * IF `DAI` surplus buffer transfers are present
    * [ ] Recipient address in the instruction is in the checksummed format
    * [ ] Recipient address matches Exec Sheet
    * [ ] Recipient address variable name matches one found in `addresses_wallets.sol`
    * [ ] Transfer amount matches Exec Sheet
-    * [ ] The transfers are tested via `testDAIPayments` test
-    * [ ] Sum of all DAI transfers tested in `testDAIPayments` matches number in the Exec Sheet
-  * IF `MKR` or `DAI` streams (`DssVest`) are created
+    * [ ] The transfers are tested via `testPayments` test
+    * [ ] Sum of all DAI transfers tested in `testPayments` matches number in the Exec Sheet


This one for sure will no longer be used. Could be removed.

amusingaxl · 2025-10-13T18:35:28Z

spell/spell-reviewer-mainnet-checklist.md

+    * IF SKY stream ([DssVestTransferrable](https://github.com/sky-ecosystem/dss-vest/blob/master/src/DssVest.sol#L463)) is present
+      * [ ] Vest contract's SKY allowance increased by the cumulative `total` (the sum of all `tot` values)


Suggested change

* IF SKY stream ([DssVestTransferrable](https://github.com/sky-ecosystem/dss-vest/blob/master/src/DssVest.sol#L463)) is present

* [ ] Vest contract's SKY allowance increased by the cumulative `total` (the sum of all `tot` values)

* IF new SKY streams ([DssVestTransferrable](https://github.com/sky-ecosystem/dss-vest/blob/master/src/DssVest.sol#L463)) are present

* [ ] Vest contract's SKY allowance increased by the cumulative total (the sum of all `tot` values)

amusingaxl · 2025-10-13T18:36:32Z

spell/spell-reviewer-mainnet-checklist.md

+    * IF SPK stream ([DssVestTransferrable](https://github.com/sky-ecosystem/dss-vest/blob/master/src/DssVest.sol#L463)) is present
+      * [ ] Vest contract's SPK allowance increased by the cumulative `total` (the sum of all `tot` values)


Suggested change

* IF SPK stream ([DssVestTransferrable](https://github.com/sky-ecosystem/dss-vest/blob/master/src/DssVest.sol#L463)) is present

* [ ] Vest contract's SPK allowance increased by the cumulative `total` (the sum of all `tot` values)

* IF new SPK streams ([DssVestTransferrable](https://github.com/sky-ecosystem/dss-vest/blob/master/src/DssVest.sol#L463)) are present

* [ ] Vest contract's SPK allowance increased by the cumulative total (the sum of all `tot` values)

amusingaxl · 2025-10-13T18:37:51Z

spell/spell-reviewer-mainnet-checklist.md

-  * [ ] Where addresses are fetched from the `ChainLog`, the variable name must match the value of the ChainLog key for that address (e.g. `MCD_VAT` rather than `vat`), except where the archive pattern differs from this pattern (e.g. MKR)
+  * [ ] Fetch addresses as type `address` and wrap with `Like` suffix interfaces inline (when making calls), UNLESS archive patterns permit otherwise (such as `SKY`)
+  * [ ] Use the [DssExecLib Core Address Helpers](https://github.com/sky-ecosystem/dss-exec-lib/blob/master/src/DssExecLib.sol#L166) where possible (e.g. `DssExecLib.vat()`)
+  * [ ] Where addresses are fetched from the ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. `MCD_VAT` rather than `vat`), EXCEPT where the archive pattern differs from this pattern


I'd suggest we remove this exception, as it doesn't bring any value.

Suggested change

* [ ] Where addresses are fetched from the ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. `MCD_VAT` rather than `vat`), EXCEPT where the archive pattern differs from this pattern

* [ ] Where addresses are fetched from the ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. `MCD_VAT` rather than `vat`)

amusingaxl · 2025-10-13T18:38:32Z

spell/spell-reviewer-mainnet-checklist.md

-  * [ ] Exec Doc for the specified date is found in the [`makerdao/community` GitHub repo](https://github.com/makerdao/community/tree/master/governance/votes)
-  * [ ] Exec Doc file name follows the format `Executive vote - Month DD, YYYY.md`
+  * [ ] Exec Doc for the specified date is found in the [`sky-ecosystem/executive-votes` GitHub repo](https://github.com/sky-ecosystem/executive-votes)
+  * [ ] Exec Doc is located in the directory matching the target spell date year (e.g. `2025/`)


Nit: we can be more generic here:

Suggested change

* [ ] Exec Doc is located in the directory matching the target spell date year (e.g. `2025/`)

* [ ] Exec Doc is located in the directory matching the target spell date year (e.g. `YYYY/`)

spell/spell-crafter-mainnet-workflow.md

SidestreamBurningBanana added 3 commits September 29, 2025 15:19

Refresh the checklists to match latest practices

48517d3

Add SPK and USDS to wordlist

76c7d35

Minor adjustments

a85c611

SidestreamBurningBanana marked this pull request as ready for review October 8, 2025 08:56

amusingaxl reviewed Oct 8, 2025

View reviewed changes

Address review and add other changes

9902cd7

SidestreamBurningBanana requested a review from riccardopersiani October 8, 2025 20:11

riccardopersiani reviewed Oct 9, 2025

View reviewed changes

Address review

628bcc3

amusingaxl reviewed Oct 13, 2025

View reviewed changes

Remove DAI transfers, address nits

02bcd3d

riccardopersiani previously approved these changes Oct 16, 2025

View reviewed changes

oddaf reviewed Oct 23, 2025

View reviewed changes

spell/spell-crafter-mainnet-workflow.md Outdated Show resolved Hide resolved

Update branch name, remove extra brackets

2eb603e

SidestreamStrongStrawberry dismissed riccardopersiani’s stale review via 2eb603e October 23, 2025 12:56

riccardopersiani requested review from oddaf and riccardopersiani October 23, 2025 13:02

riccardopersiani approved these changes Oct 23, 2025

View reviewed changes

oddaf approved these changes Oct 23, 2025

View reviewed changes

SidestreamColdMelon merged commit ae35b45 into master Oct 24, 2025
2 checks passed

SidestreamColdMelon deleted the refresh-checklists branch October 24, 2025 08:29

This was referenced Oct 24, 2025

Update Spell Crafter Workflow #52

Closed

Update Reviewer Checklist #53

Closed

refactor: Update executive vote repository to makerdao/executive-votes #46

Closed

	* [ ] Test DAI/MKR/USDS/SKY/SPK streams and payments, lerps
	* [ ] Test the sum of all DAI/MKR/USDS/SKY/SPK payments matches the Exec Sheet

	* Every proof url from the Exec Sheet, such as `Reasoning URL` and `Authority URL`:
	* [ ] Is present in the spell code under relevant section or instruction (depending on which row the url is present)
	* [ ] Has the `https` scheme
	* [ ] Has prefix derived from the url itself
	* `// Executive Vote:` if URL starts with `https://vote.sky.money/executive/`
	* `// Poll:` if URL starts with `https://vote.sky.money/polling/`
	* `// Forum:` if URL starts with `https://forum.sky.money/t/`
	* `// MIP:` if URL starts with `https://mips.makerdao.com/mips/details/`
	* `// Atlas:` if URL starts with `https://sky-atlas.powerhouse.io/`

	* IF `MKR` transfers are present
	* [ ] Recipient address in the instruction is in the checksummed format
	* [ ] Recipient address matches Exec Sheet
	* [ ] Recipient address variable name matches one found in `addresses_wallets.sol`
	* [ ] Transfer amount matches Exec Sheet
	* [ ] Transfer amount is specified with (at least) 2 decimals using `ether` keyword
	* [ ] IF `ether` keyword is used, comment is present on the same line `// Note: ether is a keyword helper, only MKR is transferred here`
	* [ ] The transfers are tested via `testPayments` test
	* [ ] Sum of all MKR transfers tested in `testPayments` matches number in the Exec Sheet
	* IF `SKY` transfers are present
	* [ ] Recipient address in the instruction is in the checksummed format
	* [ ] Recipient address matches Exec Sheet
	* [ ] Recipient address variable name matches one found in `addresses_wallets.sol`
	* [ ] Transfer amount matches Exec Sheet
	* [ ] The transfers are tested via `testPayments` test
	* [ ] Sum of all SKY transfers tested in `testPayments` matches number in the Exec Sheet
	* IF `DAI` surplus buffer transfers are present
	* [ ] Recipient address in the instruction is in the checksummed format
	* [ ] Recipient address matches Exec Sheet
	* [ ] Recipient address variable name matches one found in `addresses_wallets.sol`
	* [ ] Transfer amount matches Exec Sheet
	* [ ] The transfers are tested via `testPayments` test
	* [ ] Sum of all DAI transfers tested in `testPayments` matches number in the Exec Sheet
	* IF `USDS` surplus buffer transfers are present
	* [ ] Recipient address in the instruction is in the checksummed format
	* [ ] Recipient address matches Exec Sheet
	* [ ] Recipient address variable name matches one found in `addresses_wallets.sol`
	* [ ] Transfer amount matches Exec Sheet
	* [ ] The transfers are tested via `testPayments` test
	* [ ] Sum of all USDS transfers tested in `testPayments` matches number in the Exec Sheet
	* IF `MKR` / `DAI` / `SKY` / `USDS` / `SPK` streams (`DssVest`) are created

	* IF MKR stream ([DssVestTransferrable](https://github.com/sky-ecosystem/dss-vest/blob/master/src/DssVest.sol#L463)) is present
	* [ ] Vest contract's MKR allowance increased by the cumulative `total` (the sum of all `tot` values)
	* [ ] Ensure allowance increase follows archive patterns
	* IF SKY stream ([DssVestTransferrable](https://github.com/sky-ecosystem/dss-vest/blob/master/src/DssVest.sol#L463)) is present
	* [ ] Vest contract's SKY allowance increased by the cumulative `total` (the sum of all `tot` values)
	* [ ] Ensure allowance increase follows archive patterns
	* IF SPK stream ([DssVestTransferrable](https://github.com/sky-ecosystem/dss-vest/blob/master/src/DssVest.sol#L463)) is present
	* [ ] Vest contract's SPK allowance increased by the cumulative `total` (the sum of all `tot` values)
	* [ ] Ensure allowance increase follows archive patterns
	* [ ] Tested via:
	* `testVestDai`
	* `testVestMkr`
	* `testVestSky`
	* `testVestSkyMint`
	* `testVestUsds`
	* `testVestSpk`
	* IF `MKR` / `DAI` / `SKY` / `USDS` / `SPK` vest termination (`Yank`) is present
	* [ ] Yanked stream ID matches Exec Sheet
	* [ ] `MCD_VEST_MKR_TREASURY` chainlog address is used for MKR stream `yank`
	* [ ] `MCD_VEST_SKY_TREASURY` chainlog address is used for SKY stream `yank`
	* [ ] `MCD_VEST_SPK_TREASURY` chainlog address is used for SPK stream `yank`
	* [ ] `MCD_VEST_DAI` chainlog address is used for DAI stream `yank`
	* [ ] `MCD_VEST_USDS` chainlog address is used for USDS stream `yank`
	* [ ] Tested via:
	* `testYankDAI`
	* `testYankMKR`
	* `testYankSky`
	* `testYankSkyMint`
	* `testYankUsds`
	* `testYankSpk`

	* [ ] Only single import layout is used (e.g. `import { VatAbstract } from "dss-interfaces/dss/VatAbstract.sol";`)
	* [ ] Only single import layout is used (e.g. `import {VatAbstract} from "dss-interfaces/dss/VatAbstract.sol";`)

	* [ ] Where addresses are fetched from the ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. `MCD_VAT` rather than `vat`), EXCEPT where the archive pattern differs from this pattern
	* [ ] Where addresses are fetched from the ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. `MCD_VAT` rather than `vat`)

	* [ ] Exec Doc is located in the directory matching the target spell date year (e.g. `2025/`)
	* [ ] Exec Doc is located in the directory matching the target spell date year (e.g. `YYYY/`)

Refresh the checklists to match latest practices #54

Refresh the checklists to match latest practices #54

Uh oh!

Conversation

SidestreamBurningBanana commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Differences from #52 and #53

Missing in this PR

Added in this PR

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amusingaxl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SidestreamBurningBanana commented Oct 13, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

SidestreamBurningBanana commented Oct 8, 2025 •

edited

Loading