Update Reviewer Checklist #53
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of community
2 tasks
amusingaxl
reviewed
Oct 3, 2025
| * [ ] Transfer amount matches Exec Sheet | ||
| * [ ] Transfer amount is specified with (at least) 2 decimals using `ether` keyword | ||
| * [ ] IF `ether` keyword is used, comment is present on the same line `// Note: ether is a keyword helper, only MKR is transferred here` | ||
| * [ ] IF `ether` keyword is used, comment is present on the same line `// Note: ether is a keyword helper, only SKY is transferred here` |
There was a problem hiding this comment.
We could turn this check into a general one if we don't reference the token expliclitly.
Suggested change
| * [ ] IF `ether` keyword is used, comment is present on the same line `// Note: ether is a keyword helper, only SKY is transferred here` | |
| * [ ] IF `ether` keyword is used, comment is present on the same line `// Note: ether is a keyword that represents 10**18, not the ETH token` |
amusingaxl
reviewed
Oct 3, 2025
| * [ ] `usr` address variable name match one found in `addresses_wallets.sol` | ||
| * [ ] `tot` (Total stream amount) matches Exec Sheet | ||
| * [ ] IF `ether` keyword is used, comment is present on the same line `// Note: ether is a keyword helper, only MKR is transferred here` | ||
| * [ ] IF `ether` keyword is used, comment is present on the same line `// Note: ether is a keyword helper, only SKY is transferred here` |
There was a problem hiding this comment.
Same as above.
Suggested change
| * [ ] IF `ether` keyword is used, comment is present on the same line `// Note: ether is a keyword helper, only SKY is transferred here` | |
| * [ ] IF `ether` keyword is used, comment is present on the same line `// Note: ether is a keyword that represents 10**18, not the ETH token` |
There was a problem hiding this comment.
Addressed in 7b03757
riccardopersiani
requested review from
SidestreamColdMelon,
SidestreamStrongStrawberry and
amusingaxl
amusingaxl
reviewed
Oct 7, 2025
Comment on lines
8
to
9
| * [ ] Find the first [Foundry release](https://github.com/foundry-rs/foundry/releases) that is older than 7 days from now | ||
| * [ ] Insert the release URL here: |
There was a problem hiding this comment.
Remove these lines.
Suggested change
| * [ ] Find the first [Foundry release](https://github.com/foundry-rs/foundry/releases) that is older than 7 days from now | |
| * [ ] Insert the release URL here: |
There was a problem hiding this comment.
I added this suggestion on the SideStream PR.
|
Closing as #54 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.