feat(dmsg): surface the dmsg-server connection protocol (tcp/ws/wss/webtransport/quic)#3507
Merged
Merged
Conversation
…ebtransport/quic)
0pcom
force-pushed
the
feat/dmsg-connection-protocol
branch
from
July 17, 2026 21:54
049442f to
0d0140e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Surface the underlying protocol a visor's dmsg client(s) use to reach each dmsg server —
tcp/ws/wss/webtransport/quic— from the CLI, the visor RPC/HTTP API, and the wasm (browser) visor's self-summary.Until now the carrier a session was dialed over was recorded internally (
SessionCommon.carrier, used by the browser wss→WebTransport upgrade) but never exposed. You could see which dmsg servers a client was connected to, not how.Why
Groundwork for the wasm-visor onboarding tour, which will explain dmsg-servers-as-anonymous-relay and the connection protocol (which differs for a browser visor over http vs https, and again for a host-native visor). More generally it's a useful diagnostic: a native visor connects over
tcp, a browser tab overwss/webtransport, and now you can tell at a glance — including from a shell.Changes
pkg/dmsg/dmsg):SessionCommon.Carrier()/CarrierAddr()/Protocol()accessors; record the dialed endpoint in a newcarrierAddrfield;ProtocolLabel(carrier, addr)helper that distinguishes plainws://from TLSwss://by endpoint scheme and rendersacceptedfor inbound server-side sessions. Unit-tested.pkg/visor): newDmsgServerSession{pk,carrier,protocol,address};DmsgClientSessionInfogains a parallelsessionsfield (the existingservers []PubKeyis kept untouched for back-compat).DmsgSessions()populates it fromAllSessions().skywire cli dmsg sessionsprints the protocol next to each server (falls back to bare PKs against an older visor).cmd/wasm-visor):SelfDmsgSessions()emits the samesessionsshape so the shared Angular UI and the tour get the browser edge's ws/wss/webtransport per server.Validation
go test ./pkg/dmsg/dmsg(newTestProtocolLabel), native +GOOS=js GOARCH=wasmbuilds, gofmt/vet clean.dmsg sessionsshowstcpfor every server across themainandtransport_setupclients;--json→{pk, carrier:"tcp", protocol:"tcp", address:"172.105.179.5:30085"}withservers[]still present.🤖 Generated with Claude Code