fix: respect the configured receive window#291
Open
paulpach wants to merge 1 commit intoskywind3000:masterfrom
Open
fix: respect the configured receive window#291paulpach wants to merge 1 commit intoskywind3000:masterfrom
paulpach wants to merge 1 commit intoskywind3000:masterfrom
Conversation
the count should be less than the configured receive window, not the default receive window
Contributor
|
hey @skywind3000 can you confirm that this is a bug? |
miwarnec
pushed a commit
to MirrorNetworking/kcp2k
that referenced
this pull request
Nov 28, 2021
… windows/messages than defaults for skywind3000/kcp#291
miwarnec
pushed a commit
to MirrorNetworking/kcp2k
that referenced
this pull request
Nov 28, 2021
… windows/messages than defaults for skywind3000/kcp#291
miwarnec
pushed a commit
to MirrorNetworking/kcp2k
that referenced
this pull request
Nov 28, 2021
…based on receive window size. #22 skywind3000/kcp#291
miwarnec
pushed a commit
to MirrorNetworking/kcp2k
that referenced
this pull request
Nov 28, 2021
…based on receive window size. #22 skywind3000/kcp#291
Contributor
|
we have a applied this fix for C# kcp version. 我们在 C# 版本中修复了它。它工作正常。 |
miwarnec
pushed a commit
to MirrorNetworking/Mirror
that referenced
this pull request
Nov 28, 2021
- uncorks max message size from 144 KB to as much as we want based on
receive window size.
fixes MirrorNetworking/kcp2k#22
fixes skywind3000/kcp#291
- feature: OnData now includes channel it was received on
- fixes #2989
Contributor
|
这里应该是 if (count >= 256) return -2; 才对吧，frg字段只有一个字节。 |
sh4k3n
added a commit
to sh4k3n/kcp
that referenced
this pull request
Nov 30, 2021
Contributor
Thank you. We noticed this too just now. |
|
@skywind3000 This is your project which is supposed to be a replacement for TCP (Most used protocol in the world). Why have you not merged this pull request yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the count should be less than the configured receive window, not the default receive window