fix: Use non-traditional RoPE in Qwen2 test case.#56
Merged
skyzh merged 1 commit intoskyzh:mainfrom Sep 7, 2025
Merged
Conversation
skyzh
approved these changes
Sep 7, 2025
jiengup
added a commit
to jiengup/tiny-llm
that referenced
this pull request
Sep 8, 2025
|
I don’t quite understand this change. Literally speaking, doesn’t |
jiengup
added a commit
to jiengup/tiny-llm
that referenced
this pull request
Sep 9, 2025
This reverts commit 4db096e.
Closed
jiengup
added a commit
to jiengup/tiny-llm
that referenced
this pull request
Sep 9, 2025
This reverts commit bf3383d.
Contributor
Author
Sorry for misunderstand the original code. I've create aonther PR to revert this commit. #62 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since you claim that "The Qwen2 model uses a non-traditional form of RoPE" in the tutorial book, maybe it's better to use a non-traditional RoPE test case and notify the followers.