enable setting slow DAC voltage in human readable format from the client #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables setting slow DAC voltage from the client in a human-readable format by adding setter functionality for Vdac variables. Key changes include:
- Adding linkedSet support to pr.LinkVariable for Vdac_0 to Vdac_4.
- Introducing a new static method, revConvtFloat, for converting human-readable values to DAC register values.
- Modifying the conversion format in the revConvtFloat method.
Contributor
|
@JennySmith888 Reminder that new feature request for FW/SW get directed to pre-release (not main). I have updated this PR direction for you to be pre-release |
ruck314
approved these changes
Apr 18, 2025
king-pietro
approved these changes
Apr 21, 2025
Co-authored-by: Copilot <[email protected]>
JennySmith888
deleted the
jpsmith/make-slow-dac-voltage-writable-from-client
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add set ability for
Vdac_*Was it correct to return an int:
return '%d'%(intValue)and not a 2-byte hex?
return '%04x'%(intValue)The GUI field shows hex: