Skip to content

[bug]: accept OpenRouter limit_remaining null (free tier) #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
log0u7 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[bug]: accept OpenRouter limit_remaining null (free tier) #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81181c5
fix(openrouter): accept limit_remaining null for free-tier keys
Aug 27, 2026
67f951a
test(openrouter): align free-tier expectation with actual entry shape
Aug 28, 2026
12acbcb
style: wrap openrouter remaining check to satisfy biome formatter
log0u7 Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/lib/quota-providers-remote.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,7 +681,9 @@ function parseOpenRouterKeyV1(
(limit !== null &&
limit !== undefined &&
(typeof limit !== "number" || !Number.isFinite(limit) || limit < 0)) ||
(remaining !== undefined && (typeof remaining !== "number" || !Number.isFinite(remaining)))
(remaining !== null &&
remaining !== undefined &&
(typeof remaining !== "number" || !Number.isFinite(remaining)))
) {
return { success: false, error: "Invalid openrouter-key-v1 response" };
}
Expand Down
28 changes: 21 additions & 7 deletions tests/lib.quota-providers-remote.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,18 +325,32 @@ describe("quota provider remote runtime", () => {
}
});

it("rejects OpenRouter remaining above its positive limit", async () => {
it("accepts OpenRouter free-tier (limit_remaining: null)", async () => {
vi.stubGlobal(
"fetch",
vi
.fn()
.mockResolvedValue(jsonResponse({ data: { usage: 0, limit: 10, limit_remaining: 11 } })),
.mockResolvedValue(
jsonResponse({ data: { usage: 0.106921435, limit: null, limit_remaining: null } }),
),
);
await expect(
fetchRemoteQuotaProvider(source({ format: "openrouter-key-v1" }), "secret"),
).resolves.toEqual({
success: false,
error: "Invalid openrouter-key-v1 response",
const result = await fetchRemoteQuotaProvider(
source({ format: "openrouter-key-v1" }),
"secret",
);
expect(result.success).toBe(true);
expect(result.entries[0]).toEqual({
accounting: {
resultType: "spend",
acquisitionMethod: "remote_api",
ownership: "user_configured",
authority: "provider_reported",
},
kind: "value",
name: "Source One spend",
group: "Source One",
label: "Spend:",
value: "$0.11",
});
});

Expand Down