i32 index fixes #180
Open
i32 index fixes #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slyalin
reviewed
Dec 19, 2024
| SmallVector<int64_t> order(coords.begin(), coords.end()); | ||
| SmallVector<int64_t> order; | ||
| if (ov_order_element_type == ov::element::i64) { | ||
| ov::Coordinate coords = const_order->get_coordinate_val(); |
Owner
There was a problem hiding this comment.
Indices in const_order as the second input of Transpose cannot be negative, so you can just use const_order->cast_vector<uint64_t>() and leave negative indices as UB.
Collaborator
Author
There was a problem hiding this comment.
Right, I tried that, but got only partial result for some reason. Half of the values were correct, others - zeroes.
Owner
There was a problem hiding this comment.
Make sure that you used cast_vector, not get_vector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are what I have found while experimenting with different small models. When the type of an index is i32 it doesn't fit into an mlir op and there might be problems with accessing them through the constant op on OV side (I'd seen partial data for example). There are quick fixes for the issues I've seen so far.