Skip to content

i32 index fixes #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kurapov-peter wants to merge 3 commits into
base: mlir
Choose a base branch
from
Open

i32 index fixes #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f3e7d0
Fix a problem with gather index type
kurapov-peter Dec 16, 2024
b0fe372
Allow both i32 and i64 input types for transpose
kurapov-peter Dec 9, 2024
1edc6de
Use cast_vector instead of conditional coords
kurapov-peter Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added src/cmake/123
View file
Open in desktop
Empty file.
4 changes: 3 additions & 1 deletion src/common/transformations/src/transformations/mlir/op/gather.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,15 @@ struct ConvertGather {
auto empty_add = builder.create<tensor::EmptyOp>(loc, indices_expanded.getType(), dynamic_index_dims);
auto add = builder.create<linalg::AddOp>(loc, mlir::ValueRange{cast.getResult(), indices_expanded}, mlir::ValueRange{empty_add});
auto select = builder.create<linalg::SelectOp>(loc, mlir::ValueRange{cmpi.getResult(), add.getResult(0), indices_expanded}, mlir::ValueRange{empty_add});
auto index_type = RankedTensorType::get(ArrayRef(importShape(ov_output_shape)), builder.getIndexType());
auto cast2 = builder.create<arith::IndexCastOp>(loc, index_type, mlir::ValueRange{select.getResult(0)});

auto gather_node = std::dynamic_pointer_cast<ov::op::util::GatherBase>(node);
assert(gather_node && "Expected a gather node");
int64_t axis = gather_node->get_axis();

llvm::SmallVector<int64_t> gather_dims{axis};
auto gather = builder.create<tensor::GatherOp>(loc, out_type, input, select.getResult(0), gather_dims, false);
auto gather = builder.create<tensor::GatherOp>(loc, out_type, input, cast2, gather_dims, false);
context.addOutputs(node, gather);
}
};
Expand Down
3 changes: 2 additions & 1 deletion src/common/transformations/src/transformations/mlir/op/transpose.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,11 @@ struct ConvertTranspose {
const auto ov_output_shape = node->get_output_partial_shape(0);
auto out_type = importTensor(context.context, ov_output_shape, ov_output_element_type);
auto dynamic_dimensions = context.get_dynamic_dimension_values(ov_output_shape);
const auto ov_order_element_type = node->get_input_element_type(1);

auto const_order = dynamic_cast<ov::op::v0::Constant*>(node->get_input_node_ptr(1));
assert(const_order && "non-const order not supported");
ov::Coordinate coords = const_order->get_coordinate_val();
std::vector<int64_t> coords = const_order->cast_vector<int64_t>();
SmallVector<int64_t> order(coords.begin(), coords.end());

auto empty = builder.create<tensor::EmptyOp>(loc, out_type, dynamic_dimensions);
Expand Down
Loading