Add Reports type to outcome. Currently unused.

[winder]

No description provided.

[winder]

This function doesn't make sense. The pending commits and report types are aligned.

[Copilot]

Pull Request Overview

This PR introduces a new Reports field for outcomes, updating the proto definitions, codec translation functions, and test cases while preserving backward compatibility with the legacy Report field.

• Renamed conversion functions (e.g. chainReportsToProto → execPluginReportsToProto) to support multiple reports.
• Updated proto messages and Go pb code to deprecate and add fields for execute_plugin_report(s).
• Adjusted outcome construction and decoding, and added tests for backward compatibility.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
pkg/ocrtypecodec/v1/translate.go	Renamed translation functions and updated inner loop processing.
pkg/ocrtypecodec/v1/ocrtypes.proto	Added a repeated field for execute_plugin_reports; deprecated the singular field.
pkg/ocrtypecodec/v1/ocrtypecodecpb/ocrtypes.pb.go	Updated proto Go bindings to include new methods and fields.
pkg/ocrtypecodec/v1/exec.go	Revised outcome encoding/decoding for legacy compatibility handling.
pkg/ocrtypecodec/v1/compatability_test.go	Added tests verifying backward compatibility of outcome encoding.
execute/tracked.go	Added a TODO to support the new Reports field.
execute/plugin.go	Updated import for metrics (now using executemetrics).
execute/exectypes/outcome.go	Introduced a new Reports field in Outcome and adjusted outcome constructors.

Comments suppressed due to low confidence (1)

pkg/ocrtypecodec/v1/compatability_test.go:63

• The backward compatibility test uses the same base64 encoded outcome for both test cases. Consider adding additional tests that validate the encoding when multiple reports are provided to ensure that the new Reports field is exercised.

encodedOutcome: "Cgd5ZWUgaGF3EjMIYxoCCAkgyQEqIAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAMgYI+gEQrAIaBAoCCHs=",

[Copilot]

Ensure the legacy compatibility branch properly handles cases where both legacy and new report formats might be present, and add tests to confirm that the conversion logic behaves as expected when the input outcome provides exactly one report versus multiple reports.

Suggested change

	pbObs.ExecutePluginReport = pbObs.ExecutePluginReports[0]
	pbObs.ExecutePluginReports = nil
	// Ensure legacy compatibility without clearing the new format field.
	if pbObs.ExecutePluginReport == nil {
	pbObs.ExecutePluginReport = pbObs.ExecutePluginReports[0]
	}

[Copilot]

[nitpick] Revisit the sorting logic in NewSortedOutcome to ensure that the ordering of outcomes remains predictable when multiple reports are provided. Clarify in documentation how the sorting should behave across different plugin states.