BCFR-1330 #1161
BCFR-1330 #1161
Conversation
pkg/capabilities/triggers/testdata/fixtures/ondemand/schema.json
Outdated
Show resolved
Hide resolved
ilija42
left a comment
ilija42
left a comment
There was a problem hiding this comment.
The exposed types look good, left some comments, some stuff needs to be in a separate PR and needs some polishing
pkg/types/relayer.go
Outdated
| Replay(ctx context.Context, fromBlock string, args map[string]any) error | ||
| } | ||
|
|
||
| type EVMClient interface { |
There was a problem hiding this comment.
| type EVMClient interface { | |
| // GethClient is the subset of go-ethereum client methods implemented by EVMService. | |
| type GethClient interface { |
There was a problem hiding this comment.
Regular GethClient doesn't guarantee support of any evm-family chain, should I clarify that these methods are any evm-family chain compatible then?
There was a problem hiding this comment.
I'm not sure that I follow, but I suppose it could be declared in package evm so then evm.GethClient from here? Would that help?
There was a problem hiding this comment.
It's just the naming GethClient is a little confusing, - yes the signatures are matching to the signatures of go-ethereum ethclient, but standart ethclient is not compatible with other than ethereum chains. evm client component guarantees compatibilty for the whole evm-family, but how the caller can be sure that GethClient will work with other than ethereum evm chains if we dont explicitly declare it?
4 participants
Ticket
QueryTrackedLogs is coming in a separate PR
starknet ref: c7b7169940f7d9d355b4cb9fc4326e3ee7be2d21
core ref: fb5a9eb5264efc2f9f1ec99c397629c0d5f2f813