Skip to content

implement extended evm service interface #17496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
May 9, 2025
Merged

implement extended evm service interface #17496

merged 39 commits into from
May 9, 2025

Conversation

Unheilbar
Copy link
Collaborator

@Unheilbar Unheilbar commented Apr 29, 2025

Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

Copy link
Contributor

@ilija42 ilija42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about detaching this from the relayer and having an evm chain service in the evm repo?

@Unheilbar Unheilbar marked this pull request as ready for review May 1, 2025 21:11
@Unheilbar Unheilbar requested review from a team as code owners May 1, 2025 21:11
@Unheilbar Unheilbar requested review from vyzaldysanchez and a team May 1, 2025 21:11
@Unheilbar Unheilbar closed this May 5, 2025
@Unheilbar Unheilbar reopened this May 5, 2025

This comment was marked as resolved.

This comment was marked as resolved.

@Unheilbar
Copy link
Collaborator Author

WDYT about detaching this from the relayer and having an evm chain service in the evm repo?

Maybe we can move it to chainlink-evm with a separate PR later

@jmank88
Copy link
Contributor

jmank88 commented May 9, 2025

WDYT about detaching this from the relayer and having an evm chain service in the evm repo?

Maybe we can move it to chainlink-evm with a separate PR later

Anything that can be declared in chainlink-evm (i.e. no dependencies on packages in this repo) should be put there now. Otherwise it just new tech debt blocking the ongoing evm extraction.
Edit: This seems to have dependencies? so nbd for now

@cl-sonarqube-production
Copy link

@patrickhuie19 patrickhuie19 added this pull request to the merge queue May 9, 2025
Merged via the queue into develop with commit fd80c7a May 9, 2025
140 of 145 checks passed
@patrickhuie19 patrickhuie19 deleted the BCFR-1330 branch May 9, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants