Skip to content

Conversation

pkcll
Copy link
Contributor

@pkcll pkcll commented Oct 15, 2025

Summary

Adds optional MeterProvider and TracerProvider configuration to chipingress client and updates beholder to pass its providers.

Related PR

Changes

  • chipingress: Add WithMeterProvider() and WithTracerProvider() options
  • chipingress: Update README with custom provider examples
  • beholder: Pass MeterProvider and TracerProvider to chipingress client

Testing

  • All existing tests pass
  • Backward compatible: uses global OTel providers if not set

Jira: INFOPLAT-3070

Copy link

👋 pkcll, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copy link

github-actions bot commented Oct 15, 2025

✅ API Diff Results - No breaking changes


📄 View full apidiff report

@pkcll pkcll changed the title chipingress: add optional OTel providers, beholder: pass providers to chipingress chipingress: instrument with OTel metrics and tracing Oct 15, 2025
@pkcll pkcll requested review from jmank88 and patrickhuie19 and removed request for justinkaseman and thomaska October 15, 2025 14:55
@patrickhuie19 patrickhuie19 merged commit 9362b18 into main Oct 16, 2025
19 of 22 checks passed
@patrickhuie19 patrickhuie19 deleted the INFOPLAT-3070-chip-ingress-otel-metrics-tracing branch October 16, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants