-
Notifications
You must be signed in to change notification settings - Fork 325
[OPDATA-3889] FTSE SFTP EA Downloading and Parsing #4027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 9a8ca73 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
const parsedData = await this.tryDownloadAndParseFile(param.instrument) | ||
|
||
// Extract the numeric result based on the data type | ||
let result: number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to ResponseGeneric we need some sort of result
} | ||
} finally { | ||
try { | ||
await this.sftpClient.end() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
private async tryDownloadAndParseFile(instrument: string): Promise<IndexResponseData> { | ||
// Validate that the instrument is supported | ||
if (!isInstrumentSupported(instrument)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I should move this validation up to handleRequest
?
This is replaced by #4036 |
Closes https://smartcontract-it.atlassian.net/browse/OPDATA-3889
Description
Steps to Test
Quality Assurance
infra-k8s
configuration file.adapter-secrets
configuration file or update the soak testing blacklist.test-payload.json
file with relevant requests.feature/x
,chore/x
,release/x
,hotfix/x
,fix/x
) or is created from Jira.