-
Notifications
You must be signed in to change notification settings - Fork 325
OPDATA-3889: FTSE sFTP EA #4036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 80d40de The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
adf3530
to
0ac3976
Compare
mxiao-cll
reviewed
Sep 19, 2025
mxiao-cll
approved these changes
Sep 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait for release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/OPDATA-3889
Description
This PR adds the transport functionality for the FTSE SFTP external adapter, making it functional for the first time.
The EA downloads a CSV file from SFTP and parses the current value of a specified index out of it.
Previous PRs added utilities for downloading the file and parsing the CSV.
This PR brings all of it together.
The PR is based on this PR by @chray-zhang. Because he's on vacation I decided to clean it up instead of reviewing it.
Additionally I first split out these PRs to make this PR easier to review:
I made this PR 2 separate commits. The first commit has Chray's changes from the original PR and the second commit has my change on top of it. But I recommend reviewing it as a single change.
Changes
filename
in the response data to make it clear which file was used to parse the index value from.ftse_sftp
tosftp
to avoid unnecessary redundancy.ftse-sftp
from README black list.Steps to Test
Quality Assurance
infra-k8s
configuration file.adapter-secrets
configuration file or update the soak testing blacklist.test-payload.json
file with relevant requests.feature/x
,chore/x
,release/x
,hotfix/x
,fix/x
) or is created from Jira.