-
Notifications
You must be signed in to change notification settings - Fork 8
fix: batch job ID and label prior to submission #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThis update adds a new method Changes
Sequence Diagram(s)sequenceDiagram
participant Client as Job Submission
participant Executor as GoogleBatchExecutor
participant Fixer as fix_job_name
Client->>Executor: Submit job (with name)
Executor->>Fixer: Call fix_job_name(job.name)
Fixer-->>Executor: Return sanitized name
Executor->>Executor: Generate labels/jobid using sanitized name
Executor->>Client: Return processed job data
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be improved by using the single action, to be consistent with how it is done throughout the org now:
- https://github.com/snakemake/snakemake/blob/4574c9286defa55b0c0b0fcc5a0d36b33b939db8/.github/workflows/main.yml#L88
- https://github.com/snakemake/snakemake-executor-plugin-aws-batch/blob/cc4df2fd7d3b629c3b12168066d4e25897b66436/.github/workflows/ci_mocked_api.yml#L94C7-L99C21
- https://github.com/snakemake/snakemake-storage-plugin-s3/blob/7495115ae28a732d7d7d8f8fbb92e90f5b182ad1/.github/workflows/ci.yml#L85C7-L90C21
- name: Setup minio
uses: comfuture/minio-action@v1
with:
access_key: minio
secret_key: minio123
port: 9000
Allowing to also not need the docker-compose.yml
Co-authored-by: Jake VanCampen <[email protected]>
This PR addresses the issues with job names submitted to Google Batch that are too long or have incorrect characters.
Closes #57 and #55.
Summary by CodeRabbit
New Features
Chores