-
Notifications
You must be signed in to change notification settings - Fork 43
docs: added notes about ntasks per gpu #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughDocumentation update in docs/further.md clarifies SLURM behavior: if cpus_per_gpu <= 0 or tasks_per_gpu <= 0, no CPU request is made and --ntasks-per-gpu is not set. No code or API changes. Changes
Sequence Diagram(s)Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
🤖 I have created a release *beep* *boop* --- ## [1.6.1](v1.6.0...v1.6.1) (2025-08-21) ### Bug Fixes * efficiency report jobsteps ([#338](#338)) ([a4cbe36](a4cbe36)) * gpu tasks are unset if <= 0 ([#347](#347)) ([564e0f7](564e0f7)) * updated poetry ([#343](#343)) ([58d471d](58d471d)) ### Documentation * added notes about ntasks per gpu ([#346](#346)) ([adcd86e](adcd86e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Bug Fixes - Corrected efficiency report job step handling. - Prevented invalid GPU task settings by unsetting values ≤ 0. - Documentation - Added guidance on configuring tasks per GPU. - Chores - Updated packaging tooling and version to 1.6.1. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
just a minor addendum to the docs
Summary by CodeRabbit