-
Notifications
You must be signed in to change notification settings - Fork 16
fix: exclude the .snakemake
folder from the watcher and searches
#41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: exclude the .snakemake
folder from the watcher and searches
#41
Conversation
📝 WalkthroughWalkthroughThis pull request modifies the Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
27-29
: Glob Pattern Consideration forsearch.exclude
The glob pattern used forsearch.exclude
is"**/.snakemake"
, which may work as intended. However, consider whether appending a trailing wildcard (e.g.,"**/.snakemake/**"
) might more reliably exclude all nested files within the folder. This change depends on the desired exclusion depth.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
package.json
(1 hunks)
🔇 Additional comments (1)
package.json (1)
23-30
: Clear Addition of Configuration Defaults
The newconfigurationDefaults
section undercontributes
is correctly defined and structured. It will effectively exclude the.snakemake
directory from file watching and searches. Please ensure that these defaults merge with any existing user settings as specified by the VSCode API documentation.
.snakemake
folder from the watcher and searches.snakemake
folder from the watcher and searches
.snakemake
folder from the watcher and searches.snakemake
folder from the watcher and searches
Thanks a lot! @Hocnonsense could you confirm whether this works as intended? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adds a few settings to avoid explosive searches (#37).
I believe the API will merge these values without overriding existing ones (see here).
configurationDefaults should modify the default configuration without adding user-seen options.
I have omitted
python.analysis.exclude
because any changes will overwrite existing settings. This seems to be unavoidable, until the python extension uses a more sensible approach to this setting.Word of caution: I am not versed in VSCode extensions!
So please check carefully before merging.
Summary by CodeRabbit