Skip to content

SNOW-1405682 - disable use of GCS default credentials as a default #2117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfc-gh-pmotacki merged 2 commits into from
Mar 11, 2025
Merged

SNOW-1405682 - disable use of GCS default credentials as a default #2117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da12d5f
SNOW-1405682 - disable use of GCS default credentials
sfc-gh-pmotacki Mar 11, 2025
aee5205
SNOW-1405682 - disable use of GCS default credentials
sfc-gh-pmotacki Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/net/snowflake/client/core/SFBaseSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public abstract class SFBaseSession {
private boolean enableExactSchemaSearch = false;

/** Disable lookup for default credentials by GCS library */
private boolean disableGcsDefaultCredentials = false;
private boolean disableGcsDefaultCredentials = true;

private Map<String, Object> commonParameters;

Expand Down
3 changes: 1 addition & 2 deletions src/main/java/net/snowflake/client/jdbc/cloud/storage/SnowflakeGCSClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1372,8 +1372,7 @@ private static void overrideHost(StageInfo stage, StorageOptions.Builder builder

private static boolean areDisabledGcsDefaultCredentials(SFSession session) {
return session != null && session.getDisableGcsDefaultCredentials()
|| convertSystemPropertyToBooleanValue(
DISABLE_GCS_DEFAULT_CREDENTIALS_PROPERTY_NAME, false);
|| convertSystemPropertyToBooleanValue(DISABLE_GCS_DEFAULT_CREDENTIALS_PROPERTY_NAME, true);
}

private static boolean isSuccessStatusCode(int code) {
Expand Down
Loading