SNOW-1405682 - disable use of GCS default credentials as a default#2117
Merged
sfc-gh-pmotacki merged 2 commits intomasterfrom Mar 11, 2025
Merged
SNOW-1405682 - disable use of GCS default credentials as a default#2117sfc-gh-pmotacki merged 2 commits intomasterfrom
sfc-gh-pmotacki merged 2 commits intomasterfrom
Conversation
sfc-gh-mkubik
approved these changes
Mar 11, 2025
sfc-gh-mhofman
approved these changes
Mar 11, 2025
a832856 to
aee5205
Compare
sfc-gh-pfus
approved these changes
Mar 11, 2025
Contributor
|
@sfc-gh-pmotacki can you plz write some description? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-1405682 - disable the use of GCS default credentials as a default
We decided to set the value of
disableGcsDefaultCredentialstotrueaccording to information that the current default configuration is wrong and generates a lot of customer frustration. When the customer uses the GCS global credential provider it is impossible to connect to the GCS storage driver because of incorrect credentials.Pre-review self checklist
masterbranchmvn -P check-style validate)mvn verifyand inspecttarget/japicmp/japicmp.html)SNOW-XXXX:External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: #NNNN
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.