Skip to content

SNOW-1405682 - disable use of GCS default credentials as a default#2117

Merged
sfc-gh-pmotacki merged 2 commits intomasterfrom
SNOW-1405682-disable-gcs-credentials
Mar 11, 2025
Merged

SNOW-1405682 - disable use of GCS default credentials as a default#2117
sfc-gh-pmotacki merged 2 commits intomasterfrom
SNOW-1405682-disable-gcs-credentials

Conversation

@sfc-gh-pmotacki
Copy link
Copy Markdown
Contributor

@sfc-gh-pmotacki sfc-gh-pmotacki commented Mar 11, 2025

Overview

SNOW-1405682 - disable the use of GCS default credentials as a default
We decided to set the value of disableGcsDefaultCredentials to true according to information that the current default configuration is wrong and generates a lot of customer frustration. When the customer uses the GCS global credential provider it is impossible to connect to the GCS storage driver because of incorrect credentials.

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner March 11, 2025 11:19
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1405682-disable-gcs-credentials branch from a832856 to aee5205 Compare March 11, 2025 11:25
@sfc-gh-mhofman
Copy link
Copy Markdown
Contributor

@sfc-gh-pmotacki can you plz write some description?

@sfc-gh-pmotacki sfc-gh-pmotacki merged commit 32fa12c into master Mar 11, 2025
138 of 142 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-1405682-disable-gcs-credentials branch March 11, 2025 14:41
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants