Skip to content

feat: use gaf sast settings [IDE-724] #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

feat: use gaf sast settings [IDE-724] #813

wants to merge 26 commits into from

Conversation

acke
Copy link
Contributor

@acke acke commented Mar 28, 2025 •
edited
Loading

Description

Changes in Snyk Language Server:

  • Snyk Language Server gets the sast settings and the UserAgent from the Go Application Framework Configuration.
  • Moved sast_settings.go from /internal/api/contract to local_workflows/code_workflow/sast_contract to be used in snyk-ls.
  • Introduced a new constant for the new sast settings called ConfigurationSastSettings in /pkg/local_workflows/code_workflow/native_workflow.go
  • Removed references to sastsettings in ApiClient.

Checklist

  • Tests added and all succeed
  • Linted
  • README.md updated, if user-facing
  • License file updated, if new 3rd-party dependency is introduced

@acke acke changed the title Feat/ide 724 use gaf sast settings feat: use gaf sast settings [IDE-724] Mar 28, 2025
@acke acke force-pushed the feat/IDE-724_use_gaf_sast_settings branch 2 times, most recently from 0d33b14 to a669367 Compare March 28, 2025 14:52
@acke acke force-pushed the feat/IDE-724_use_gaf_sast_settings branch from a669367 to d07bc92 Compare March 28, 2025 15:13
@acke acke force-pushed the feat/IDE-724_use_gaf_sast_settings branch from e5c35c9 to 619e0b4 Compare March 28, 2025 18:48
@acke acke force-pushed the feat/IDE-724_use_gaf_sast_settings branch from 619e0b4 to f363d4f Compare March 28, 2025 21:02
@acke acke force-pushed the feat/IDE-724_use_gaf_sast_settings branch from 15452c4 to 90316a4 Compare March 31, 2025 13:43
@acke acke force-pushed the feat/IDE-724_use_gaf_sast_settings branch from d770e05 to 75c979b Compare April 15, 2025 18:48
@acke acke requested a review from rrama April 15, 2025 18:54
@acke acke force-pushed the feat/IDE-724_use_gaf_sast_settings branch from 75c979b to d0786eb Compare April 16, 2025 08:12
bastiandoetsch
bastiandoetsch requested changes Apr 16, 2025
View reviewed changes
Copy link
Collaborator

@bastiandoetsch bastiandoetsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't mock in smoke tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastiandoetsch bastiandoetsch bastiandoetsch requested changes

@rrama rrama Awaiting requested review from rrama

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acke @rrama @bastiandoetsch