feat: use gaf sast settings [IDE-724]

README.md

@@ -338,7 +338,7 @@ Right now the language server supports the following actions:
 - `SettingsSastEnabled` triggers the api call to check if Snyk Code is enabled
   - command: `snyk.getSettingsSastEnabled`
   - args: empty
-  - returns `true` if enabled, `false` if not, or an error and false if an error occurred
+  - returns a `*sast_contract.SastResponse` or, or an error and false if an error occurred
 - `GetActiveUser` triggers the api call to get the active logged in user or an error if not logged in
   - command: `snyk.getActiveUser`
   - args: empty

application/server/server.go

@@ -218,7 +218,10 @@ func workspaceDidChangeWorkspaceFoldersHandler(c *config.Config, srv *jrpc2.Serv
 
 func initNetworkAccessHeaders() {
 	engine := config.CurrentConfig().Engine()
-	ua := util.GetUserAgent(engine.GetConfiguration(), config.Version)
+	gafConfig := engine.GetConfiguration()
+	ua := util.GetUserAgent(gafConfig, config.Version)
+	engine.GetNetworkAccess().RemoveHeaderField("x-snyk-cli-version")
+	engine.GetNetworkAccess().AddHeaderField("x-snyk-ide", ua.AppVersion)
 	engine.GetNetworkAccess().AddHeaderField("User-Agent", ua.String())
 }
 

application/server/server_smoke_test.go

@@ -31,6 +31,8 @@ import (
 	"github.com/creachadair/jrpc2/server"
 	"github.com/go-git/go-git/v5"
 	"github.com/rs/zerolog"
+	"github.com/snyk/go-application-framework/pkg/local_workflows/code_workflow"
+	"github.com/snyk/go-application-framework/pkg/local_workflows/code_workflow/sast_contract"
 	sglsp "github.com/sourcegraph/go-lsp"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -210,6 +212,7 @@ func Test_SmokeIssueCaching(t *testing.T) {
 		c.SetSnykOssEnabled(true)
 		c.SetSnykIacEnabled(false)
 		di.Init()
+		setSastEnabled(c, true)
 
 		var cloneTargetDirGoof = setupRepoAndInitialize(t, testsupport.NodejsGoof, "0336589", loc, c)
 		cloneTargetDirGoofString := (string)(cloneTargetDirGoof)
@@ -286,6 +289,7 @@ func Test_SmokeIssueCaching(t *testing.T) {
 		c.SetSnykOssEnabled(true)
 		c.SetSnykIacEnabled(false)
 		di.Init()
+		setSastEnabled(c, true)
 
 		var cloneTargetDirGoof = setupRepoAndInitialize(t, testsupport.NodejsGoof, "0336589", loc, c)
 		folderGoof := c.Workspace().GetFolderContaining(cloneTargetDirGoof)
@@ -495,6 +499,7 @@ func runSmokeTest(t *testing.T, c *config.Config, repo string, commit string, fi
 	c.SetSnykOssEnabled(true)
 	cleanupChannels()
 	di.Init()
+	setSastEnabled(c, true)
 
 	cloneTargetDir := setupRepoAndInitialize(t, repo, commit, loc, c)
 	cloneTargetDirString := (string)(cloneTargetDir)
@@ -849,6 +854,7 @@ func Test_SmokeSnykCodeFileScan(t *testing.T) {
 	c.SetSnykCodeEnabled(true)
 	cleanupChannels()
 	di.Init()
+	setSastEnabled(c, true)
 
 	var cloneTargetDir, err = storedconfig.SetupCustomTestRepo(t, types.FilePath(t.TempDir()), testsupport.NodejsGoof, "0336589", c.Logger())
 	cloneTargetDirString := string(cloneTargetDir)
@@ -897,6 +903,7 @@ func Test_SmokeUncFilePath(t *testing.T) {
 	c.SetSnykIacEnabled(false)
 	cleanupChannels()
 	di.Init()
+	setSastEnabled(c, true)
 
 	var cloneTargetDir, err = storedconfig.SetupCustomTestRepo(t, types.FilePath(t.TempDir()), testsupport.NodejsGoof, "0336589", c.Logger())
 	if err != nil {
@@ -925,6 +932,7 @@ func Test_SmokeSnykCodeDelta_NewVulns(t *testing.T) {
 	c.SetDeltaFindingsEnabled(true)
 	cleanupChannels()
 	di.Init()
+	setSastEnabled(c, true)
 	scanAggregator := di.ScanStateAggregator()
 	fileWithNewVulns := "vulns.js"
 	var cloneTargetDir, err = storedconfig.SetupCustomTestRepo(t, types.FilePath(t.TempDir()), testsupport.NodejsGoof, "0336589", c.Logger())
@@ -972,6 +980,7 @@ func Test_SmokeSnykCodeDelta_NoNewIssuesFound(t *testing.T) {
 	cleanupChannels()
 	di.Init()
 	scanAggregator := di.ScanStateAggregator()
+	setSastEnabled(c, true)
 
 	fileWithNewVulns := "vulns.js"
 	var cloneTargetDir, err = storedconfig.SetupCustomTestRepo(t, types.FilePath(t.TempDir()), "https://github.com/snyk-labs/nodejs-goof", "0336589", c.Logger())
@@ -1002,6 +1011,7 @@ func Test_SmokeSnykCodeDelta_NoNewIssuesFound_JavaGoof(t *testing.T) {
 	cleanupChannels()
 	di.Init()
 	scanAggregator := di.ScanStateAggregator()
+	setSastEnabled(c, true)
 
 	var cloneTargetDir, err = storedconfig.SetupCustomTestRepo(t, types.FilePath(t.TempDir()), "https://github.com/snyk-labs/java-goof", "f5719ae", c.Logger())
 	assert.NoError(t, err)
@@ -1021,6 +1031,13 @@ func Test_SmokeSnykCodeDelta_NoNewIssuesFound_JavaGoof(t *testing.T) {
 	assert.Equal(t, 0, len(issueList), "no issues expected, as delta and no new change")
 }
 
+func setSastEnabled(c *config.Config, b bool) {
+	c.Engine().GetConfiguration().Set(code_workflow.ConfigurationSastSettings, &sast_contract.SastResponse{SastEnabled: b, LocalCodeEngine: sast_contract.LocalCodeEngine{
+		Enabled: false,
+	},
+	})
+}
+
 func ensureInitialized(t *testing.T, c *config.Config, loc server.Local, initParams types.InitializeParams) {
 	t.Helper()
 	t.Setenv("SNYK_LOG_LEVEL", "info")

domain/ide/codelens/codelens_test.go

@@ -20,6 +20,8 @@ import (
 	"context"
 	"testing"
 
+	"github.com/snyk/go-application-framework/pkg/local_workflows/code_workflow"
+	"github.com/snyk/go-application-framework/pkg/local_workflows/code_workflow/sast_contract"
 	"github.com/stretchr/testify/assert"
 
 	"github.com/snyk/snyk-ls/application/di"
@@ -46,7 +48,7 @@ func Test_GetCodeLensForPath(t *testing.T) {
 	c := testutil.IntegTest(t)
 	di.TestInit(t) // IntegTest doesn't automatically inits DI
 	testutil.OnlyEnableCode()
-
+	c.Engine().GetConfiguration().Set(code_workflow.ConfigurationSastSettings, &sast_contract.SastResponse{SastEnabled: true})
 	// this is using the real progress channel, so we need to listen to it
 	dummyProgressListeners(t)
 

domain/ide/command/command_factory.go

@@ -57,8 +57,7 @@ func CreateFromCommandData(c *config.Config, commandData types.CommandData, srv
 	case types.OpenLearnLesson:
 		return &openLearnLesson{command: commandData, srv: srv, learnService: learnService}, nil
 	case types.GetSettingsSastEnabled:
-		apiClient := snyk_api.NewSnykApiClient(c, httpClient)
-		return &sastEnabled{command: commandData, apiClient: apiClient, logger: c.Logger(), authenticationService: authService}, nil
+		return &sastEnabled{command: commandData, logger: c.Logger(), authenticationService: authService, c: c}, nil
 	case types.GetFeatureFlagStatus:
 		apiClient := snyk_api.NewSnykApiClient(c, httpClient)
 		return &featureFlagStatus{command: commandData, apiClient: apiClient, authenticationService: authService}, nil

domain/ide/command/sast_enabled.go

@@ -21,16 +21,18 @@ import (
 
 	"github.com/rs/zerolog"
 
+	"github.com/snyk/snyk-ls/application/config"
 	"github.com/snyk/snyk-ls/infrastructure/authentication"
-	"github.com/snyk/snyk-ls/infrastructure/snyk_api"
 	"github.com/snyk/snyk-ls/internal/types"
+
+	"github.com/snyk/go-application-framework/pkg/local_workflows/code_workflow"
 )
 
 type sastEnabled struct {
 	command               types.CommandData
-	apiClient             snyk_api.SnykApiClient
 	logger                *zerolog.Logger
 	authenticationService authentication.AuthenticationService
+	c                     *config.Config
 }
 
 func (cmd *sastEnabled) Command() types.CommandData {
@@ -45,6 +47,11 @@ func (cmd *sastEnabled) Execute(_ context.Context) (any, error) {
 		return nil, nil
 	}
 
-	sastResponse, err := cmd.apiClient.SastSettings()
-	return sastResponse, err
+	gafConfig := cmd.c.Engine().GetConfiguration()
+	sastResponse, err := gafConfig.GetWithError(code_workflow.ConfigurationSastSettings)
+	if err != nil {
+		return nil, err
+	}
+
+	return sastResponse, nil
 }

go.mod

@@ -24,29 +24,29 @@ require (
 	github.com/pkg/errors v0.9.1
 	github.com/puzpuzpuz/xsync v1.5.2
 	github.com/puzpuzpuz/xsync/v3 v3.5.1
-	github.com/rs/zerolog v1.33.0
+	github.com/rs/zerolog v1.34.0
 	github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06
 	github.com/shirou/gopsutil v3.21.11+incompatible
 	github.com/snyk/code-client-go v1.20.1
-	github.com/snyk/go-application-framework v0.0.0-20250325133828-3ffd1aa4f76f
+	github.com/snyk/go-application-framework v0.0.0-20250415184029-4e8fc50fc812
 	github.com/sourcegraph/go-lsp v0.0.0-20240223163137-f80c5dd31dfd
 	github.com/spf13/pflag v1.0.6
 	github.com/stretchr/testify v1.10.0
 	github.com/subosito/gotenv v1.6.0
 	github.com/writeas/go-strip-markdown v2.0.1+incompatible
 	go.lsp.dev/uri v0.3.0
 	golang.org/x/exp v0.0.0-20250215185904-eff6e970281f
-	golang.org/x/mod v0.23.0
-	golang.org/x/net v0.35.0
+	golang.org/x/mod v0.24.0
+	golang.org/x/net v0.38.0
 	golang.org/x/oauth2 v0.27.0
-	golang.org/x/sync v0.11.0
+	golang.org/x/sync v0.13.0
 	gopkg.in/ini.v1 v1.67.0
 )
 
 require (
 	dario.cat/mergo v1.0.1 // indirect
 	github.com/Microsoft/go-winio v0.6.2 // indirect
-	github.com/ProtonMail/go-crypto v1.1.5 // indirect
+	github.com/ProtonMail/go-crypto v1.1.6 // indirect
 	github.com/alexbrainman/sspi v0.0.0-20210105120005-909beea2cc74 // indirect
 	github.com/apapsch/go-jsonmerge/v2 v2.0.0 // indirect
 	github.com/aymanbagabas/go-osc52/v2 v2.0.1 // indirect
@@ -58,12 +58,12 @@ require (
 	github.com/dprotaso/go-yit v0.0.0-20240618133044-5a0af90af097 // indirect
 	github.com/emirpasic/gods v1.18.1 // indirect
 	github.com/fsnotify/fsnotify v1.5.4 // indirect
-	github.com/getkin/kin-openapi v0.129.0 // indirect
+	github.com/getkin/kin-openapi v0.131.0 // indirect
 	github.com/go-git/gcfg v1.5.1-0.20230307220236-3a3c6141e376 // indirect
 	github.com/go-git/go-billy/v5 v5.6.2 // indirect
 	github.com/go-ole/go-ole v1.2.6 // indirect
-	github.com/go-openapi/jsonpointer v0.21.0 // indirect
-	github.com/go-openapi/swag v0.23.0 // indirect
+	github.com/go-openapi/jsonpointer v0.21.1 // indirect
+	github.com/go-openapi/swag v0.23.1 // indirect
 	github.com/gofrs/flock v0.12.1 // indirect
 	github.com/golang/groupcache v0.0.0-20241129210726-2c02b8208cf8 // indirect
 	github.com/hashicorp/go-uuid v1.0.3 // indirect
@@ -92,10 +92,10 @@ require (
 	github.com/muesli/termenv v0.15.2 // indirect
 	github.com/oapi-codegen/oapi-codegen/v2 v2.4.1 // indirect
 	github.com/oapi-codegen/runtime v1.1.1 // indirect
-	github.com/oasdiff/yaml v0.0.0-20241214135536-5f7845c759c8 // indirect
-	github.com/oasdiff/yaml3 v0.0.0-20241214160948-977117996672 // indirect
+	github.com/oasdiff/yaml v0.0.0-20250309154309-f31be36b4037 // indirect
+	github.com/oasdiff/yaml3 v0.0.0-20250309153720-d2182401db90 // indirect
 	github.com/otiai10/mint v1.6.3 // indirect
-	github.com/pact-foundation/pact-go/v2 v2.2.0 // indirect
+	github.com/pact-foundation/pact-go/v2 v2.4.1 // indirect
 	github.com/pelletier/go-toml v1.9.5 // indirect
 	github.com/pelletier/go-toml/v2 v2.2.3 // indirect
 	github.com/perimeterx/marshmallow v1.1.5 // indirect
@@ -108,7 +108,7 @@ require (
 	github.com/snyk/go-httpauth v0.0.0-20231117135515-eb445fea7530 // indirect
 	github.com/speakeasy-api/jsonpath v0.6.1 // indirect
 	github.com/speakeasy-api/openapi-overlay v0.10.1 // indirect
-	github.com/spf13/afero v1.12.0 // indirect
+	github.com/spf13/afero v1.14.0 // indirect
 	github.com/spf13/cast v1.5.0 // indirect
 	github.com/spf13/cobra v1.9.1 // indirect
 	github.com/spf13/jwalterweatherman v1.1.0 // indirect
@@ -123,10 +123,11 @@ require (
 	github.com/xeipuuv/gojsonschema v1.2.0 // indirect
 	github.com/yosida95/uritemplate/v3 v3.0.2 // indirect
 	github.com/yusufpapurcu/wmi v1.2.4 // indirect
-	golang.org/x/crypto v0.35.0 // indirect
-	golang.org/x/sys v0.30.0 // indirect
-	golang.org/x/text v0.22.0 // indirect
-	golang.org/x/tools v0.30.0 // indirect
+	golang.org/x/crypto v0.37.0 // indirect
+	golang.org/x/sys v0.32.0 // indirect
+	golang.org/x/text v0.24.0 // indirect
+	golang.org/x/tools v0.31.0 // indirect
+	google.golang.org/genproto/googleapis/rpc v0.0.0-20250409194420-de1ac958c67a // indirect
 	gopkg.in/warnings.v0 v0.1.2 // indirect
 	gopkg.in/yaml.v2 v2.4.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect