Skip to content

fix: change DropZoneEmptyUploadButton from span to button for better accessibility#334

Merged
t0ngk merged 2 commits into
mainfrom
tong/fix/drop-zone-empty-button
Feb 23, 2026
Merged

fix: change DropZoneEmptyUploadButton from span to button for better accessibility#334
t0ngk merged 2 commits into
mainfrom
tong/fix/drop-zone-empty-button

Conversation

@t0ngk
Copy link
Copy Markdown
Member

@t0ngk t0ngk commented Feb 23, 2026

Why did you create this PR

  • span didn't have disabled attribute

What did you do

  • change span to button

Screenshots / Recordings

CleanShot 2569-02-23 at 11 53 12@2x

Checklist

  • Self-reviewed your code
  • Wrote coverage tests
  • Added screenshots or recordings if applicable

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 23, 2026

🦋 Changeset detected

Latest commit: 7a1d32b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@genseki/react Patch
@example/erp Patch
@example/ui-playground Patch
@genseki/next Patch
@genseki/plugins Patch
@genseki/prisma-generator Patch
@genseki/react-query Patch
@genseki/rest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Change DropZoneEmptyUploadButton from span to button for better accessibility.
@t0ngk t0ngk merged commit 443f4c9 into main Feb 23, 2026
1 check passed
@t0ngk t0ngk deleted the tong/fix/drop-zone-empty-button branch February 23, 2026 04:59
@github-actions github-actions Bot mentioned this pull request Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants