Skip to content

fix: change DropZoneEmptyUploadButton from span to button for better accessibility #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t0ngk merged 2 commits into from
Feb 23, 2026
Merged

fix: change DropZoneEmptyUploadButton from span to button for better accessibility #334

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9416eb0
fix: change DropZoneEmptyUploadButton from span to button for better …
t0ngk Feb 23, 2026
7a1d32b
Improve accessibility of DropZoneEmptyUploadButton
t0ngk Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions legacies/react/v2/components/primitives/drop-zone.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,15 +255,15 @@ export const DropZoneEmptyUploadButton = ({
variant="outline"
asChild
children={
<span
<button
className={cn(
'group-disabled/dropzone:bg-surface-primary-disabled group-disabled/dropzone:active:bg-surface-primary-disabled group-disabled/dropzone:cursor-default',
className
)}
>
<PaperclipIcon />
<span>Upload {maxFiles === 1 ? 'a file' : 'files'}</span>
</span>
</button>
}
{...props}
/>
Expand Down
Loading