Android: Fix didOpenExternalUrl not being called
#234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #233.
After changing the dependency to Hotwire Native Android, opening an external (cross-domain) URL does not trigger the
didOpenExternalUrlmethod, as that has been removed from Hotwire Native Android.This means all visit proposals, including ones that the navigators are not able to handle, as they are 'external', to be proposed for internal navigation.
This PR fixes this by comparing the host of the WebView with the host of the proposed location and calls
didOpenExternalUrlinstead.Test plan:
Follow an external link. It should open the browser (default behavior)onOpenExternalUrl={(location) => { console.log(location) }to theVisitableView, tap external link, confirm that the location is logged to the console.