Skip to content

Android: Fix didOpenExternalUrl not being called #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pfeiffer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Android: Fix didOpenExternalUrl not being called #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/turbo/android/src/main/java/com/reactnativehotwirewebview/RNVisitableView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import android.webkit.CookieManager
import android.webkit.WebView
import android.widget.LinearLayout
import androidx.appcompat.widget.AppCompatImageView
import androidx.core.net.toUri
import androidx.core.view.isVisible
import androidx.lifecycle.findViewTreeLifecycleOwner
import androidx.lifecycle.lifecycleScope
Expand Down Expand Up @@ -328,6 +329,12 @@ class RNVisitableView(context: Context) : LinearLayout(context), SessionSubscrib
}

override fun visitProposedToLocation(location: String, options: VisitOptions) {
val currentUrl = webView?.url
if (currentUrl != null && currentUrl.toUri().host != location.toUri().host) {
didOpenExternalUrl(location)
return
}

sendEvent(RNVisitableViewEvent.VISIT_PROPOSAL, Arguments.createMap().apply {
putString("url", location)
putString("action", options.action.name.lowercase())
Expand Down