feat: add telemetry to Maestro, extension activation #1807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
latekvo
approved these changes
Dec 10, 2025
Comment on lines
+58
to
+68
| if (deviceInfo.platform === DevicePlatform.IOS) { | ||
| if (deviceInfo.deviceType === DeviceType.Tablet) { | ||
| return DeviceFamily.IPAD_SIMULATOR; | ||
| } | ||
| return DeviceFamily.IPHONE_SIMULATOR; | ||
| } | ||
|
|
||
| if (deviceInfo.emulator) { | ||
| return DeviceFamily.ANDROID_EMULATOR; | ||
| } | ||
| return DeviceFamily.ANDROID_PHYSICAL; |
Member
There was a problem hiding this comment.
Just to be sure, we don't want to be checking deviceInfo.deviceType on android devices? (feel free to ignore if this is a dumb question)
Contributor
Author
There was a problem hiding this comment.
We don't set it for Androids, it's always Phone (at this time, at least)
jwajgelt
added a commit
that referenced
this pull request
Dec 12, 2025
Adds telemetry events: - on extension activation, with the editor type (vscode vs cursor vs windsurf) - on maestro tests starting/completing/failing, with the device family (iPhone/iPad simulator, physical/emulated Android) What? Internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds telemetry events:
How Has This Been Tested:
What?
How Has This Change Been Documented:
Internal