fix: don`t refetch Android phone models list on fail #1818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jwajgelt
added a commit
that referenced
this pull request
Dec 12, 2025
Changes the behaviour of `DeviceNameCache` so that if the model list fetch fails, the extension won't attempt to refetch it. This should prevent making unnecessary request and spamming the IDE logs with errors when e.g. the machine doesn't have Internet access. ### How Has This Been Tested: - open Radon in Radon - connect a physical Android device - disconnect from the Internet - remove the `~/Library/Application Support/Code/User/globalStorage/swmansion.react-native-ide/RNIDE_device_models.json` file - verify "Error fetching device models: fetch failed" isn't logged more than once ### How Has This Change Been Documented: Internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the behaviour of
DeviceNameCacheso that if the model list fetch fails, the extension won't attempt to refetch it.This should prevent making unnecessary request and spamming the IDE logs with errors when e.g. the machine doesn't have Internet access.
How Has This Been Tested:
~/Library/Application Support/Code/User/globalStorage/swmansion.react-native-ide/RNIDE_device_models.jsonfileHow Has This Change Been Documented:
Internal