Skip to content

fix: don`t refetch Android phone models list on fail #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwajgelt merged 1 commit into from
Dec 12, 2025
Merged

fix: don`t refetch Android phone models list on fail #1818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/vscode-extension/src/devices/DeviceNameCache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,10 @@ async function getDeviceModels(refetchIfNotOnList?: string): Promise<DeviceModel
if (json) {
await writeCacheFile(json);
}
fetchModelsPromise = null;
// NOTE: even if `fetchModelsPromise` resolves to null, we don't want to reset it,
// in order to avoid attempting refetching the models list over and over.
// Instead, we rely on it only being called once per extension activation here,
// so the list can be re-fetched only after restart.
return json;
}

Expand Down
Loading